From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 1/3] xen/atomic: Introduce common atomic
 header and update includes
Date: Wed, 2 Jul 2014 15:07:36 +0100
Message-ID: <53B41228.6030407@citrix.com>
References: <1404308871-23368-1-git-send-email-andrew.cooper3@citrix.com>
	<1404308871-23368-2-git-send-email-andrew.cooper3@citrix.com>
	<53B42CC1020000780001F96D@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53B42CC1020000780001F96D@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 02/07/14 15:01, Jan Beulich wrote:
>>>> On 02.07.14 at 15:47, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/arch/x86/apic.c
>> +++ b/xen/arch/x86/apic.c
>> @@ -28,7 +28,7 @@
>>  #include <xen/softirq.h>
>>  #include <asm/mc146818rtc.h>
>>  #include <asm/msr.h>
>> -#include <asm/atomic.h>
>> +#include <xen/atomic.h>
> I appreciate you having taken the time to replace all these, but - do
> we really need to do this replacement at this point? Especially arch
> code should be fine using the asm/ header instad of the xen/ one.
>
> Jan
>

Not strictly, but I figured it was cleaner to update everything at once
than to have a mix of common and arch specific includes.

(Also it didn't take long at all.  `git grep ... | xargs sed` is a
remakably quick refactoring tool, and gcc will quickly tell you if it
went wrong)

~Andrew