All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel@lists.xensource.com
Cc: apatel@apm.com, Ian.Campbell@citrix.com, psawargaonkar@apm.com
Subject: Re: [PATCH] xen/arm: introduce platform_need_explicit_eoi
Date: Wed, 02 Jul 2014 15:49:53 +0100	[thread overview]
Message-ID: <53B41C11.9050705@linaro.org> (raw)
In-Reply-To: <1403271316-21635-1-git-send-email-stefano.stabellini@eu.citrix.com>

Hi Stefano,

The commit title doesn't reflect the patch. You don't add a new
platform_need_explicit_eoi but a new quirk.

On 06/20/2014 02:35 PM, Stefano Stabellini wrote:
> +/*
> + * Quirk for platforms where GICH_LR_HW does not work as expected.
> + */
> +#define PLATFORM_QUIRK_NEED_EOI       (1 << 1)
> +

I would rename to PLATFORM_QUIRK_GUEST_PIRQ_NEED_EOI. So people will
directly know from the name that it's only for guest pirq.

Regards,

-- 
Julien Grall

  parent reply	other threads:[~2014-07-02 14:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 13:35 [PATCH] xen/arm: introduce platform_need_explicit_eoi Stefano Stabellini
2014-06-20 14:11 ` Julien Grall
2014-06-20 14:27   ` Stefano Stabellini
2014-06-20 14:47     ` Julien Grall
2014-06-20 16:48       ` Stefano Stabellini
2014-06-20 16:59         ` Julien Grall
2014-06-20 17:40           ` Stefano Stabellini
2014-06-20 18:33             ` Julien Grall
2014-06-21 14:43               ` Stefano Stabellini
2014-06-21 14:59                 ` Julien Grall
2014-06-21 15:26                   ` Stefano Stabellini
2014-06-21 15:59                     ` Julien Grall
2014-06-23 10:43                       ` Stefano Stabellini
2014-06-27 15:51                         ` Ian Campbell
2014-06-30 10:01                           ` Julien Grall
2014-07-02 15:31                             ` Stefano Stabellini
2014-07-02 15:34                           ` Stefano Stabellini
2014-07-02 14:49 ` Julien Grall [this message]
2014-07-02 15:31   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B41C11.9050705@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=apatel@apm.com \
    --cc=psawargaonkar@apm.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.