From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH] xen/arm: introduce
	platform_need_explicit_eoi
Date: Wed, 02 Jul 2014 15:49:53 +0100
Message-ID: <53B41C11.9050705@linaro.org>
References: <1403271316-21635-1-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1403271316-21635-1-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: apatel@apm.com, Ian.Campbell@citrix.com, psawargaonkar@apm.com
List-Id: xen-devel@lists.xenproject.org

Hi Stefano,

The commit title doesn't reflect the patch. You don't add a new
platform_need_explicit_eoi but a new quirk.

On 06/20/2014 02:35 PM, Stefano Stabellini wrote:
> +/*
> + * Quirk for platforms where GICH_LR_HW does not work as expected.
> + */
> +#define PLATFORM_QUIRK_NEED_EOI       (1 << 1)
> +

I would rename to PLATFORM_QUIRK_GUEST_PIRQ_NEED_EOI. So people will
directly know from the name that it's only for guest pirq.

Regards,

-- 
Julien Grall