diff for duplicates of <53B41CD6.8090403@ti.com> diff --git a/a/1.txt b/N1/1.txt index 7313e10..7e5c302 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -243,7 +243,7 @@ I am OK with either location. >> +{ >> + int ret = 0; >> + ->> + BUG_ON(data->tas2552_client == NULL); +>> + BUG_ON(data->tas2552_client = NULL); > don't hang the entire machine because of a bug on the amplifier driver, > WARN() should be enough, followed by the return of an error code. > @@ -255,7 +255,7 @@ Yeah I can remove this. I was following an older example. > >> + >> + mutex_lock(&data->mutex); ->> + if (power == data->power_state) +>> + if (power = data->power_state) > Same here. Is this really necessary ? It's simple to guarantee this case > won't happen in code. @@ -633,7 +633,7 @@ Yes this is backwards. Will fix >> + >> + dev = &client->dev; >> + data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL); ->> + if (data == NULL) +>> + if (data = NULL) >> + return -ENOMEM; >> + >> + if (np) { diff --git a/a/content_digest b/N1/content_digest index d236f93..1b68232 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020140702141001.GA5541@saruman.home\0" "From\0Dan Murphy <dmurphy@ti.com>\0" "Subject\0Re: [PATCH v3] ASoC: tas2552: Support TI TAS2552 Amplifier\0" - "Date\0Wed, 2 Jul 2014 09:53:10 -0500\0" + "Date\0Wed, 02 Jul 2014 14:53:10 +0000\0" "To\0balbi@ti.com\0" "Cc\0linux-sound@vger.kernel.org" linux-kernel@vger.kernel.org @@ -256,7 +256,7 @@ ">> +{\n" ">> +\tint\tret = 0;\n" ">> +\n" - ">> +\tBUG_ON(data->tas2552_client == NULL);\n" + ">> +\tBUG_ON(data->tas2552_client = NULL);\n" "> don't hang the entire machine because of a bug on the amplifier driver,\n" "> WARN() should be enough, followed by the return of an error code.\n" ">\n" @@ -268,7 +268,7 @@ ">\n" ">> +\n" ">> +\tmutex_lock(&data->mutex);\n" - ">> +\tif (power == data->power_state)\n" + ">> +\tif (power = data->power_state)\n" "> Same here. Is this really necessary ? It's simple to guarantee this case\n" "> won't happen in code.\n" "\n" @@ -646,7 +646,7 @@ ">> +\n" ">> +\tdev = &client->dev;\n" ">> +\tdata = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);\n" - ">> +\tif (data == NULL)\n" + ">> +\tif (data = NULL)\n" ">> +\t\treturn -ENOMEM;\n" ">> +\n" ">> +\tif (np) {\n" @@ -834,4 +834,4 @@ "------------------\n" Dan Murphy -4cc59ad75ce341ac45d212e80e1b7fe41dc0d4dcdf084daf3b38666d0e186643 +d172d7ef98f4b80242f08e4b8f199aa7f83f044fefa17a6dfebf00099ce0649b
diff --git a/a/content_digest b/N2/content_digest index d236f93..d2ac0c3 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,12 +3,12 @@ "From\0Dan Murphy <dmurphy@ti.com>\0" "Subject\0Re: [PATCH v3] ASoC: tas2552: Support TI TAS2552 Amplifier\0" "Date\0Wed, 2 Jul 2014 09:53:10 -0500\0" - "To\0balbi@ti.com\0" - "Cc\0linux-sound@vger.kernel.org" - linux-kernel@vger.kernel.org - alsa-devel@alsa-project.org - broonie@kernel.org - " devicetree@vger.kernel.org\0" + "To\0<balbi@ti.com>\0" + "Cc\0<linux-sound@vger.kernel.org>" + <linux-kernel@vger.kernel.org> + <alsa-devel@alsa-project.org> + <broonie@kernel.org> + " <devicetree@vger.kernel.org>\0" "\00:1\0" "b\0" "Felipe\n" @@ -834,4 +834,4 @@ "------------------\n" Dan Murphy -4cc59ad75ce341ac45d212e80e1b7fe41dc0d4dcdf084daf3b38666d0e186643 +fa608da06bb6ea909b0206451820ad15a77222dc1838462fa7b5da1e4996b0ce
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.