diff for duplicates of <53B42591.5080608@ti.com> diff --git a/a/1.txt b/N1/1.txt index 12847a0..0168f93 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -181,7 +181,7 @@ I mean you cannot turn off vbat right? >>>> +{ >>>> + int ret = 0; >>>> + ->>>> + BUG_ON(data->tas2552_client == NULL); +>>>> + BUG_ON(data->tas2552_client = NULL); >>> don't hang the entire machine because of a bug on the amplifier driver, >>> WARN() should be enough, followed by the return of an error code. >>> @@ -191,7 +191,7 @@ I mean you cannot turn off vbat right? >> >>>> + >>>> + mutex_lock(&data->mutex); ->>>> + if (power == data->power_state) +>>>> + if (power = data->power_state) >>> Same here. Is this really necessary ? It's simple to guarantee this case >>> won't happen in code. >> Yes this LOC is necessary. It is checking the current state of the tas2552. diff --git a/a/content_digest b/N1/content_digest index de8a26a..4c8a7c3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,13 +4,13 @@ "ref\020140702150259.GC5541@saruman.home\0" "From\0Dan Murphy <dmurphy@ti.com>\0" "Subject\0Re: [PATCH v3] ASoC: tas2552: Support TI TAS2552 Amplifier\0" - "Date\0Wed, 2 Jul 2014 10:30:25 -0500\0" + "Date\0Wed, 02 Jul 2014 15:30:25 +0000\0" "To\0balbi@ti.com\0" - "Cc\0devicetree@vger.kernel.org" + "Cc\0linux-sound@vger.kernel.org" + linux-kernel@vger.kernel.org alsa-devel@alsa-project.org broonie@kernel.org - linux-kernel@vger.kernel.org - " linux-sound@vger.kernel.org\0" + " devicetree@vger.kernel.org\0" "\00:1\0" "b\0" "On 07/02/2014 10:03 AM, Felipe Balbi wrote:\n" @@ -196,7 +196,7 @@ ">>>> +{\n" ">>>> +\tint\tret = 0;\n" ">>>> +\n" - ">>>> +\tBUG_ON(data->tas2552_client == NULL);\n" + ">>>> +\tBUG_ON(data->tas2552_client = NULL);\n" ">>> don't hang the entire machine because of a bug on the amplifier driver,\n" ">>> WARN() should be enough, followed by the return of an error code.\n" ">>>\n" @@ -206,7 +206,7 @@ ">>\n" ">>>> +\n" ">>>> +\tmutex_lock(&data->mutex);\n" - ">>>> +\tif (power == data->power_state)\n" + ">>>> +\tif (power = data->power_state)\n" ">>> Same here. Is this really necessary ? It's simple to guarantee this case\n" ">>> won't happen in code.\n" ">> Yes this LOC is necessary. It is checking the current state of the tas2552.\n" @@ -447,4 +447,4 @@ "------------------\n" Dan Murphy -a30f519791a7772b65e4cc5f7092df385aa82159b27d177b994eac921dc6abbc +09a40bc133eb26c56f490d3f63175e8118ac2f378c87ae7d11c5ee2afe785136
diff --git a/a/content_digest b/N2/content_digest index de8a26a..fb81469 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,12 +5,12 @@ "From\0Dan Murphy <dmurphy@ti.com>\0" "Subject\0Re: [PATCH v3] ASoC: tas2552: Support TI TAS2552 Amplifier\0" "Date\0Wed, 2 Jul 2014 10:30:25 -0500\0" - "To\0balbi@ti.com\0" - "Cc\0devicetree@vger.kernel.org" - alsa-devel@alsa-project.org - broonie@kernel.org - linux-kernel@vger.kernel.org - " linux-sound@vger.kernel.org\0" + "To\0<balbi@ti.com>\0" + "Cc\0<linux-sound@vger.kernel.org>" + <linux-kernel@vger.kernel.org> + <alsa-devel@alsa-project.org> + <broonie@kernel.org> + " <devicetree@vger.kernel.org>\0" "\00:1\0" "b\0" "On 07/02/2014 10:03 AM, Felipe Balbi wrote:\n" @@ -447,4 +447,4 @@ "------------------\n" Dan Murphy -a30f519791a7772b65e4cc5f7092df385aa82159b27d177b994eac921dc6abbc +b4fd665c47921ee4f46cded5af6e0264c882c147144a26007e00305b2f9341b9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.