From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH RFC 4/9] xenctrl: Make the headers C++ friendly Date: Wed, 2 Jul 2014 16:37:24 +0100 Message-ID: <53B42734.4080407@citrix.com> References: <1404308041-15461-1-git-send-email-rcojocaru@bitdefender.com> <1404308041-15461-4-git-send-email-rcojocaru@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404308041-15461-4-git-send-email-rcojocaru@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Razvan Cojocaru , xen-devel@lists.xen.org Cc: Ian Jackson , tim@xen.org, Ian Campbell List-Id: xen-devel@lists.xenproject.org On 02/07/14 14:33, Razvan Cojocaru wrote: > Moved an enum definition before the typedef that uses it. > > Signed-off-by: Razvan Cojocaru Reviewed-by: Andrew Cooper However, you should CC the tools maintainers for tools patches. I have done on this email. > --- > tools/libxc/xenctrl.h | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/tools/libxc/xenctrl.h b/tools/libxc/xenctrl.h > index af6f249..abd8947 100644 > --- a/tools/libxc/xenctrl.h > +++ b/tools/libxc/xenctrl.h > @@ -119,6 +119,16 @@ typedef struct xc_interface_core xc_interface; > typedef struct xc_interface_core xc_evtchn; > typedef struct xc_interface_core xc_gnttab; > typedef struct xc_interface_core xc_gntshr; > + > +enum xc_error_code { > + XC_ERROR_NONE = 0, > + XC_INTERNAL_ERROR = 1, > + XC_INVALID_KERNEL = 2, > + XC_INVALID_PARAM = 3, > + XC_OUT_OF_MEMORY = 4, > + /* new codes need to be added to xc_error_level_to_desc too */ > +}; > + > typedef enum xc_error_code xc_error_code; > > > @@ -1766,15 +1776,6 @@ int xc_hvm_inject_trap( > */ > > > -enum xc_error_code { > - XC_ERROR_NONE = 0, > - XC_INTERNAL_ERROR = 1, > - XC_INVALID_KERNEL = 2, > - XC_INVALID_PARAM = 3, > - XC_OUT_OF_MEMORY = 4, > - /* new codes need to be added to xc_error_level_to_desc too */ > -}; > - > #define XC_MAX_ERROR_MSG_LEN 1024 > typedef struct xc_error { > enum xc_error_code code;