All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads
Date: Wed, 02 Jul 2014 12:37:10 -0600	[thread overview]
Message-ID: <53B45156.1090202@wwwdotorg.org> (raw)
In-Reply-To: <1403715449-2177-1-git-send-email-swarren@wwwdotorg.org>

On 06/25/2014 10:57 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> I2C read transactions are typically implemented as follows:
> 
> START(write) address REPEATED_START(read) data... STOP
> 
> However, Tegra's I2C driver currently implements reads as follows:
> 
> START(write) address STOP START(read) data... STOP
> 
> This sequence confuses at least the AS3722 PMIC on the Jetson TK1 board,
> leading to corrupted read data in some cases. Fix the driver to chain
> the transactions together using repeated starts to solve this.

Heiko, do these patches look good?

  parent reply	other threads:[~2014-07-02 18:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 16:57 [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads Stephen Warren
2014-06-25 16:57 ` [U-Boot] [PATCH 2/3] i2c: tegra: write clean data to TX FIFO Stephen Warren
2014-06-25 23:37   ` Yen Lin
2014-06-25 23:42   ` Yen Lin
2014-06-25 16:57 ` [U-Boot] [PATCH 3/3] i2c: tegra: dump alen in debug statements Stephen Warren
2014-06-25 23:40   ` Yen Lin
2014-06-25 23:36 ` [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads Yen Lin
2014-06-26  2:12 ` Simon Glass
2014-06-26  4:09   ` Stephen Warren
2014-06-26  8:11 ` Joakim Tjernlund
2014-06-26 16:47   ` Stephen Warren
2014-06-26 19:11     ` Joakim Tjernlund
2014-06-26 19:18       ` Stephen Warren
2014-06-26 19:24         ` Stephen Warren
2014-06-26 20:01           ` Joakim Tjernlund
2014-06-26 22:54             ` Stephen Warren
2014-06-26 19:40         ` Joakim Tjernlund
2014-07-02 18:37 ` Stephen Warren [this message]
2014-07-03  4:34   ` Heiko Schocher
2014-07-21 15:14     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B45156.1090202@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.