From: "Christian König" <deathsimple@vodafone.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/radeon: page table BOs are kernel allocations
Date: Thu, 03 Jul 2014 08:49:15 +0200 [thread overview]
Message-ID: <53B4FCEB.7050805@vodafone.de> (raw)
In-Reply-To: <CADnq5_Nc8hQg7Re-s_ZwotdQNXZVqmtLdR4qwZN7vHU=eWG-3Q@mail.gmail.com>
Am 02.07.2014 21:53, schrieb Alex Deucher:
> On Wed, Jul 2, 2014 at 3:28 PM, Christian König <deathsimple@vodafone.de> wrote:
>> From: Christian König <christian.koenig@amd.com>
>>
>> Userspace shouldn't be able to access them.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> Cc: stable@vger.kernel.org
> I assume this is for 3.15. I had to tweak it slightly for 3.16.
Yeah, I've created the patch on a 3.15 branch. Didn't realized that we
need to change it slightly for 3.16.
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Thanks,
Christian.
>
>> ---
>> drivers/gpu/drm/radeon/radeon_vm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
>> index c11b71d..c8c48aa 100644
>> --- a/drivers/gpu/drm/radeon/radeon_vm.c
>> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
>> @@ -493,7 +493,7 @@ int radeon_vm_bo_set_addr(struct radeon_device *rdev,
>> mutex_unlock(&vm->mutex);
>>
>> r = radeon_bo_create(rdev, RADEON_VM_PTE_COUNT * 8,
>> - RADEON_GPU_PAGE_SIZE, false,
>> + RADEON_GPU_PAGE_SIZE, true,
>> RADEON_GEM_DOMAIN_VRAM, NULL, &pt);
>> if (r)
>> return r;
>> @@ -913,7 +913,7 @@ int radeon_vm_init(struct radeon_device *rdev, struct radeon_vm *vm)
>> return -ENOMEM;
>> }
>>
>> - r = radeon_bo_create(rdev, pd_size, RADEON_VM_PTB_ALIGN_SIZE, false,
>> + r = radeon_bo_create(rdev, pd_size, RADEON_VM_PTB_ALIGN_SIZE, true,
>> RADEON_GEM_DOMAIN_VRAM, NULL,
>> &vm->page_directory);
>> if (r)
>> --
>> 1.9.1
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-07-03 6:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 19:28 [PATCH] drm/radeon: page table BOs are kernel allocations Christian König
2014-07-02 19:53 ` Alex Deucher
2014-07-03 6:49 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B4FCEB.7050805@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.