From: Stefan Klug <stefan.klug@baslerweb.com>
To: Greg KH <greg@kroah.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stern@rowland.harvard.edu>
Subject: Re: [PATCH][RFC] USB: zerocopy support for usbfs
Date: Thu, 3 Jul 2014 09:06:45 +0200 [thread overview]
Message-ID: <53B50105.1060005@baslerweb.com> (raw)
In-Reply-To: <20140702175526.GA21063@kroah.com>
On 02.07.2014 19:55, Greg KH wrote:
> Very nice.
Thanks.
> Minor non-technical issues here, your patch is corrupted (linewrapped
> and tabs converted to spaces) and can't be applied at all. Can you fix
> your email client and try again? Look at
> Documentation/email_clients.txt for hints on how to do this.
Hm, I thought I checked that one. Sorry. I'll test and resend correctly.
>> --- a/drivers/usb/core/devio.c
>> +++ b/drivers/usb/core/devio.c
>> @@ -4,6 +4,7 @@
>> * devio.c -- User space communication with USB devices.
>> *
>> * Copyright (C) 1999-2000 Thomas Sailer (sailer@ife.ee.ethz.ch)
>> + * Copyright (C) 2014 Stefan Klug (stefan.klug@baslerweb.com)
> According to legal advice given to me, this isn't needed / true, so can
> you drop it? Or, if you have different legal advice, might I ask for
> what the legal justification is that this needs to be added?
No problem. I'll remove them.
>
>> * This program is free software; you can redistribute it and/or
>> modify
>> * it under the terms of the GNU General Public License as published
>> by
>> @@ -30,6 +31,7 @@
>> * 04.01.2000 0.2 Turned into its own filesystem
>> * 30.09.2005 0.3 Fix user-triggerable oops in async URB delivery
>> * (CAN-2005-3055)
>> + * 07.05.2014 0.4 Added zerocopy support
> No need to do this, we use git now and that's where the changelog goes.
> We should just delete this "fake changelog" entirely from this file.
I'll remove the line and maybe prepare a cleanup patch later.
Stefan Klug
Software Developer
Basler AG
An der Strusbek 60-62
22926 Ahrensburg
Germany
Tel. +49 4102 463 582
Fax +49 4102 463 46 582
Stefan.Klug@baslerweb.com
www.baslerweb.com
Vorstand: Dr.-Ing. Dietmar Ley (Vorsitzender) · John P. Jennings · Arndt Bake · Hardy Mehl
Aufsichtsratsvorsitzender: Norbert Basler
Basler AG · Amtsgericht Lübeck HRB 4090 · Ust-IdNr.: DE 135 098 121 · Steuer-Nr.: 30 292 04497 · WEEE-Reg.-Nr. DE 83888045
next prev parent reply other threads:[~2014-07-03 7:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 15:53 [PATCH][RFC] USB: zerocopy support for usbfs Stefan Klug
2014-07-02 17:55 ` Greg KH
2014-07-03 7:06 ` Stefan Klug [this message]
2014-07-02 18:24 ` Alan Stern
2014-07-02 18:49 ` Peter Stuge
2014-07-02 19:31 ` Alan Stern
2014-07-02 19:42 ` Peter Stuge
2014-07-02 20:40 ` Alan Stern
2014-07-03 7:48 ` Stefan Klug
2014-07-03 8:40 ` David Laight
2014-07-03 14:15 ` Alan Stern
2014-07-02 18:58 ` Oliver Neukum
2014-07-02 19:38 ` Alan Stern
2014-07-03 8:22 ` Stefan Klug
2014-07-04 8:55 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B50105.1060005@baslerweb.com \
--to=stefan.klug@baslerweb.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.