From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH RFC 5/9] xen: Support for VMCALL mem_events
Date: Thu, 03 Jul 2014 10:29:14 +0300
Message-ID: <53B5064A.8020807@bitdefender.com>
References: <1404308041-15461-1-git-send-email-rcojocaru@bitdefender.com>
	<1404308041-15461-5-git-send-email-rcojocaru@bitdefender.com>
	<53B445CF020000780001FB25@mail.emea.novell.com>
	<53B42B4D.3090503@bitdefender.com>
	<53B44B4C020000780001FBA7@mail.emea.novell.com>
	<53B4321C.1080407@bitdefender.com>
	<53B5141B020000780001FEE6@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53B5141B020000780001FEE6@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 07/03/2014 09:28 AM, Jan Beulich wrote:
>>>> On 02.07.14 at 18:23, <rcojocaru@bitdefender.com> wrote:
>> On 07/02/2014 07:11 PM, Jan Beulich wrote:
>>>>>> On 02.07.14 at 17:54, <rcojocaru@bitdefender.com> wrote:
>>>>>> --- a/xen/include/public/hvm/params.h
>>>>>> +++ b/xen/include/public/hvm/params.h
>>>>>> @@ -148,6 +148,8 @@
>>>>>>  #define HVM_PARAM_IOREQ_SERVER_PFN 32
>>>>>>  #define HVM_PARAM_NR_IOREQ_SERVER_PAGES 33
>>>>>>  
>>>>>> -#define HVM_NR_PARAMS          34
>>>>>> +#define HVM_PARAM_MEMORY_EVENT_VMCALL 34
>>>>>
>>>>> So why does this (used only as an argument to
>>>>> hvm_memory_event_traps()) need to be settable? I guess the patch
>>>>> description is just too brief.
>>>>
>>>> Settable?
>>>
>>> You must have a reason to make this a HVM param. That reason is
>>> what I'm asking for.
>>
>> I see. I want to be able to enable / disable this type of events. I.e.:
>>
>> if (flags & ENABLE_VMCALL)
>>     xc_set_hvm_param(xci, domain, HVM_PARAM_MEMORY_EVENT_VMCALL,
>>                      HVMPME_mode_sync);
>>
>> from the application, via libxc.
> 
> But hvm_memory_event_vmcall() simply uses the value, whether or
> not it got set. And if the receiver of the event has to anyway deal
> with instances it didn't enable, then it needs to do filtering anyway,
> and hence there's little point in making configurable the exact value
> being passed back up.

You're right, I see your point. I'll either handle it in do_hvm_op() as
well or remove it completely.


Thanks,
Razvan Cojocaru