From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
vinod.koul@intel.com, dan.j.williams@intel.com, tiwai@suse.de,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
joelf@ti.com, nsekhar@ti.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH v3 4/5] ALSA: pcm_dmaengine: Correct support for 24bits physical sample widths
Date: Thu, 03 Jul 2014 10:29:22 +0200 [thread overview]
Message-ID: <53B51462.1090805@metafoo.de> (raw)
In-Reply-To: <1404363116-10538-5-git-send-email-peter.ujfalusi@ti.com>
On 07/03/2014 06:51 AM, Peter Ujfalusi wrote:
> In case of _3LE/_3BE formats the samples are stored in 3 consecutive bytes
> without padding it to 4 bytes. This means that the DMA needs to be able to
> support 3 bytes word length in order to read/write the samples from memory
> correctly. Originally the code treated 24 bits physical length samples as
> they were 32 bits which leads to corruption when playing or recording audio.
>
> The hw.formats field has already been prepared to exclude formats not
> supported by the DMA engine in use, which means that only on platforms where
> 3 bytes is supported by the DMA will be able to use this format.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
next prev parent reply other threads:[~2014-07-03 8:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 4:51 [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support Peter Ujfalusi
2014-07-03 4:51 ` Peter Ujfalusi
2014-07-03 4:51 ` [PATCH v3 1/5] dma: Support for 3 bytes word size Peter Ujfalusi
2014-07-03 4:51 ` Peter Ujfalusi
2014-07-03 4:51 ` [PATCH v3 2/5] ALSA: pcm_dmaengine: Use the available wrapper to get physical width Peter Ujfalusi
2014-07-03 4:51 ` Peter Ujfalusi
2014-07-03 4:51 ` [PATCH v3 3/5] ASoC: generic-dmaengine-pcm: Prepare formats mask for valid physical sample sizes Peter Ujfalusi
2014-07-03 4:51 ` Peter Ujfalusi
2014-07-03 8:29 ` Lars-Peter Clausen
2014-07-03 8:29 ` Lars-Peter Clausen
2014-07-03 12:01 ` Mark Brown
2014-07-03 12:02 ` Vinod Koul
2014-07-03 13:42 ` Mark Brown
2014-07-03 13:42 ` Mark Brown
2014-07-03 16:17 ` Vinod Koul
2014-07-03 16:21 ` Mark Brown
2014-07-03 4:51 ` [PATCH v3 4/5] ALSA: pcm_dmaengine: Correct support for 24bits physical sample widths Peter Ujfalusi
2014-07-03 4:51 ` Peter Ujfalusi
2014-07-03 8:29 ` Lars-Peter Clausen [this message]
2014-07-03 4:51 ` [PATCH v3 5/5] dma: edma: Declare DMA_SLAVE_BUSWIDTH_3_BYTES as supported buswidth Peter Ujfalusi
2014-07-03 4:51 ` Peter Ujfalusi
2014-07-03 8:33 ` [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support Lars-Peter Clausen
2014-07-03 9:38 ` Vinod Koul
2014-07-03 12:02 ` Mark Brown
2014-07-04 5:34 ` Takashi Iwai
2014-07-04 17:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B51462.1090805@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=joelf@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.