Re: [PATCH v9 02/14] arch/arm: let map_mmio_regions() take pfn as parameters

[Julien Grall <julien.grall@linaro.org>]

Hi Arianna,

On 07/02/2014 07:42 PM, Arianna Avanzini wrote:
> Currently, the map_mmio_regions() function, defined for the ARM
> architecture, has parameters with paddr_t type. This interface,
> however, needs caller functions to correctly page-align addresses
> given as parameters to map_mmio_regions(). This commit changes the
> function's interface to accept page frame numbers as parameters.
> This commit also modifies caller functions in an attempt to adapt
> them to the new interface.
> This commit is meant to produce the minimum indispensable needed
> changes; these are also instrumental to making the interface of
> map_mmio_regions() symmetric with the unmap_mmio_regions() function,
> that will be introduced in one of the next commits of the series
> and will feature a pfn-based interface.
> 
> NOTE: platform-specific code has not been tested, save for the
>       sunxi and the Arndale Exynos 5 platforms (see the Tested-by
>       below for the latter).
> 
> Signed-off-by: Arianna Avanzini <avanzini.arianna@gmail.com>
> Tested-by: Julien Grall <julien.grall@citrix.com>
> Cc: Dario Faggioli <dario.faggioli@citrix.com>
> Cc: Paolo Valente <paolo.valente@unimore.it>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>
> Cc: Jan Beulich <JBeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Tim Deegan <tim@xen.org>
> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Eric Trudeau <etrudeau@broadcom.com>
> Cc: Viktor Kleinik <viktor.kleinik@globallogic.com>
> 
> ---
> 
>     v7:
>         - Remove useless decrements when using paddr_to_pfn_aligned().
> 
>     v5:
>         - Add a macro for the paddr_to_pfn(PAGE_ALIGN(...)) pattern.
>         - Hopefully improve commit description.
> 
> ---
>  xen/arch/arm/domain_build.c          |  7 ++++---
>  xen/arch/arm/gic.c                   | 20 +++++++++++---------

For this patch and the following (#3), the code has heavily change in
gic.c. Everything related to the mapping for GICv2 is now done in a
separate file gic-v2.c (see the function gicv_v2_init).

So both patches won't apply cleanly on the latest branch.

Regards,

-- 
Julien Grall