From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 2/2] make: Make "src-tarball" target
 actually make a source tarball
Date: Thu, 3 Jul 2014 12:25:25 +0100
Message-ID: <53B53DA5.8030401@eu.citrix.com>
References: <1404317712-4191-1-git-send-email-george.dunlap@eu.citrix.com>
	<1404317712-4191-2-git-send-email-george.dunlap@eu.citrix.com>
	<20140703112233.GC1635@perard.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140703112233.GC1635@perard.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Ian Jackson <ian.jackson@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 07/03/2014 12:22 PM, Anthony PERARD wrote:
> On Wed, Jul 02, 2014 at 05:15:12PM +0100, George Dunlap wrote:
>> At the moment, making a release tarball is an annoyingly manual
>> process that involves running "git archive" into a temporary directory.
> Does the source tarball would need to includes tarball of ipxe and the
> different stuff to build a stubdom ?

At the moment, AFAIK, the normal xen release tarballs do not.

We could call this target "release-tarball" instead.

>
>> +xen_root=$1
>> +desc=$2
>> +
>> +tdir=$(mktemp -d $xen_root/dist/xen.XXXXXXXX) || exit 1
> Many missing " around variables, better safe than sorry :).

Ack.

  -George