Re: [net-next-2.6 PATCH v5 1/2] bridge: fdb dumping takes a filter device

[Varka Bhadram <varkabhadram@gmail.com>]

On 07/03/2014 03:08 PM, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
>
> Dumping a bridge fdb dumps every fdb entry
> held. With this change we are going to filter
> on selected bridge port.
>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c      |    3 ++-
>   drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |    7 ++++---
>   include/linux/netdevice.h                        |    1 +
>   include/linux/rtnetlink.h                        |    1 +
>   net/bridge/br_fdb.c                              |    5 +++++
>   net/bridge/br_private.h                          |    2 +-
>   net/core/rtnetlink.c                             |    7 ++++---
>   7 files changed, 18 insertions(+), 8 deletions(-)
>
>
[...]

checkpatch.pl is giving the following warnings on this patch

WARNING: line over 80 characters
#30: FILE: drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:430:
+			struct net_device *netdev, struct net_device *filter_dev,

WARNING: line over 80 characters
#123: FILE: net/core/rtnetlink.c:2551:
+				idx = ops->ndo_fdb_dump(skb, cb, dev, NULL, idx);

WARNING: line over 80 characters
#128: FILE: net/core/rtnetlink.c:2555:
+			idx = dev->netdev_ops->ndo_fdb_dump(skb, cb, dev, NULL, idx);

total: 0 errors, 3 warnings, 0 checks, 97 lines checked

-- 
Varka Bhadram