Re: [Qemu-devel] [PATCH 1/2] coroutine: make pool size dynamic

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

On 07/03/2014 07:52 AM, Stefan Hajnoczi wrote:
> Allow coroutine users to adjust the pool size.  For example, if the
> guest has multiple emulated disk drives we should keep around more
> coroutines.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  include/block/coroutine.h | 11 +++++++++++
>  qemu-coroutine.c          | 25 +++++++++++++++++++------
>  2 files changed, 30 insertions(+), 6 deletions(-)
> 

> +
> +void qemu_coroutine_adjust_pool_size(int n)
> +{
> +    qemu_mutex_lock(&pool_lock);
> +
> +    pool_max_size += n;

Where do you check that this doesn't fall below a bare-minimum
acceptable level? Is it worth assert(pool_max_size >= 64)?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]