All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] virtio-blk-pci hot unplug broken in QEMU 2.0-rc0
Date: Thu, 03 Jul 2014 18:03:48 +0200	[thread overview]
Message-ID: <53B57EE4.2080100@redhat.com> (raw)
In-Reply-To: <CAJSP0QURqgPR40UomVFMjKNuRj6mYENARs8kn5QFT7Ckf3QQ0w@mail.gmail.com>

Il 03/07/2014 18:02, Stefan Hajnoczi ha scritto:
> Hot unplug is broken in qemu.git/master
> (92259b7f434b382fc865d1f65f7d5adeed295749 aka 2.0-rc0).
>
> It can be bisected but I won't be able to do that today.  Here are the
> details if anyone has ideas:

Most likely my fault (memory region QOMification).

Paolo

> $ x86_64-softmmu/qemu-system-x86_64 -enable-kvm -cpu host -m 1024
> -drive if=virtio,cache=none,file=test.img
> (qemu) drive_add 0 if=none,id=drive0,file=test.qcow2,format=qcow2
> (qemu) device_add virtio-blk-pci,drive=drive0,id=virtio-blk-pci0
> (qemu) device_del virtio-blk-pci0
> ERROR:qom/object.c:725:object_unref: assertion failed: (obj->ref > 0)
>
> #5  0x00007fd4b0610959 in object_unref (obj=0x7fd4b27e29f8) at qom/object.c:725
> #6  0x00007fd4b044280a in memory_region_del_subregion
> (mr=0x7fd4b25402c0, subregion=0x7fd4b27e29f8) at
> /home/stefanha/qemu/memory.c:1702
> #7  0x00007fd4b05bfdcf in pci_unregister_io_regions
> (pci_dev=0x7fd4b27e25e0) at hw/pci/pci.c:894
> #8  pci_unregister_device (dev=<optimized out>) at hw/pci/pci.c:905
> #9  0x00007fd4b0570a84 in device_unrealize (dev=0x7fd4b27e25e0,
> errp=0x7fd49cbfd8b0) at hw/core/qdev.c:196
> #10 0x00007fd4b0571f3a in device_set_realized (obj=<optimized out>,
> value=<optimized out>, errp=0x0) at hw/core/qdev.c:885
> #11 0x00007fd4b060fb8e in property_set_bool (obj=0x7fd4b27e25e0,
> v=<optimized out>, opaque=0x7fd4b2610a70, name=<optimized out>,
> errp=0x0)
>     at qom/object.c:1473
> #12 0x00007fd4b06123f7 in object_property_set_qobject
> (obj=obj@entry=0x7fd4b27e25e0, value=value@entry=0x7fd490021140,
>     name=name@entry=0x7fd4b06d70d0 "realized", errp=errp@entry=0x0) at
> qom/qom-qobject.c:24
> #13 0x00007fd4b0611010 in object_property_set_bool
> (obj=obj@entry=0x7fd4b27e25e0, value=value@entry=false,
>     name=name@entry=0x7fd4b06d70d0 "realized", errp=errp@entry=0x0) at
> qom/object.c:888
> #14 0x00007fd4b05707db in device_unparent (obj=0x7fd4b27e25e0) at
> hw/core/qdev.c:1000
> #15 0x00007fd4b0610c85 in object_unparent (obj=0x7fd4b27e25e0) at
> qom/object.c:396
> #16 0x00007fd4b0550776 in acpi_pcihp_eject_slot (s=<optimized out>,
> bsel=<optimized out>, slots=<optimized out>) at hw/acpi/pcihp.c:139
>

      reply	other threads:[~2014-07-03 16:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03 16:02 [Qemu-devel] virtio-blk-pci hot unplug broken in QEMU 2.0-rc0 Stefan Hajnoczi
2014-07-03 16:03 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B57EE4.2080100@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.