From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <53B5E0C5.8010908@linux.intel.com> Date: Thu, 03 Jul 2014 16:01:25 -0700 From: Srinivas Pandruvada MIME-Version: 1.0 To: Sachin Kamat , linux-iio@vger.kernel.org CC: jic23@kernel.org, spk.linux@gmail.com Subject: Re: [PATCH 1/7] iio: hid-sensor-press: Fix return values References: <1404369852-3255-1-git-send-email-sachin.kamat@samsung.com> In-Reply-To: <1404369852-3255-1-git-send-email-sachin.kamat@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed List-ID: Thanks for the fix. Agree with the whole series. Thanks, Srinivas On 07/02/2014 11:44 PM, Sachin Kamat wrote: > IIO_CHAN_INFO_SAMP_FREQ and IIO_CHAN_INFO_HYSTERESIS cases ignored > the actual return values (which could be -EINVAL) and instead > returned IIO_VAL_INT_PLUS_MICRO always. Return the actual value > obtained from the functions. Both functions return IIO_VAL_INT_PLUS_MICRO > upon success. > > Signed-off-by: Sachin Kamat > Cc: Srinivas Pandruvada > --- > drivers/iio/pressure/hid-sensor-press.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c > index 1cd190c..2c0d2a4 100644 > --- a/drivers/iio/pressure/hid-sensor-press.c > +++ b/drivers/iio/pressure/hid-sensor-press.c > @@ -78,7 +78,6 @@ static int press_read_raw(struct iio_dev *indio_dev, > struct press_state *press_state = iio_priv(indio_dev); > int report_id = -1; > u32 address; > - int ret; > int ret_type; > s32 poll_value; > > @@ -128,14 +127,12 @@ static int press_read_raw(struct iio_dev *indio_dev, > ret_type = IIO_VAL_INT; > break; > case IIO_CHAN_INFO_SAMP_FREQ: > - ret = hid_sensor_read_samp_freq_value( > + ret_type = hid_sensor_read_samp_freq_value( > &press_state->common_attributes, val, val2); > - ret_type = IIO_VAL_INT_PLUS_MICRO; > break; > case IIO_CHAN_INFO_HYSTERESIS: > - ret = hid_sensor_read_raw_hyst_value( > + ret_type = hid_sensor_read_raw_hyst_value( > &press_state->common_attributes, val, val2); > - ret_type = IIO_VAL_INT_PLUS_MICRO; > break; > default: > ret_type = -EINVAL;