From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/4] Add superblock checksum check for btrfs-progs
Date: Fri, 4 Jul 2014 09:10:48 +0800 [thread overview]
Message-ID: <53B5FF18.7060801@cn.fujitsu.com> (raw)
In-Reply-To: <20140703175727.GK1553@twin.jikos.cz>
-------- Original Message --------
Subject: Re: [PATCH 0/4] Add superblock checksum check for btrfs-progs
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Date: 2014年07月04日 01:57
> On Thu, Jul 03, 2014 at 05:36:34PM +0800, Qu Wenruo wrote:
>> Before this patchset, btrfs-progs will overall ignore the superblock
>> checksum and continue the routine.
>> Sometimes this may cause disasters like checking a btrfs with corrupted
>> superblock will lead to crash in btrfs-progs.
>>
>> This patch introduces superblock checksum check into btrfs_read_dev_super(),
>> making btrfs-progs much more restricted and robust.
>> To allow super-recover to open devices, add options to scan all 3
>> superblocks when using super-recover.
>> Also updated the related error string and fix a bug in chunk-recover that
>> will not be triggered until superblock csum is calculated.
>>
>> Qu Wenruo (4):
>> btrfs-progs: Check superblock's checsum when read dev super
>> btrfs-progs: Allow btrfs_read_dev_super() to read all 3 super for
>> super_recover.
>> btrfs-progs: Add more meaningful return value for
>> btrfs_read_dev_super() and corresponding error string.
>> btrfs-progs: Fix size for malloc for superblock checksum.
> Nice work. I've added 1, 2 and 4 it to integration. Please update the
> patch 3 (printf/fprintf).
Thanks for the review and minor tweak for patch 2.
I'll send v2 version of patch 3 soon.
Thank,
Qu
next prev parent reply other threads:[~2014-07-04 1:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 9:36 [PATCH 0/4] Add superblock checksum check for btrfs-progs Qu Wenruo
2014-07-03 9:36 ` [PATCH v2 1/4] btrfs-progs: Check superblock's checsum when read dev super Qu Wenruo
2014-09-15 11:36 ` David Sterba
2014-09-15 11:44 ` David Sterba
2014-09-16 5:20 ` Qu Wenruo
2014-07-03 9:36 ` [PATCH 2/4] btrfs-progs: Allow btrfs_read_dev_super() to read all 3 super for super_recover Qu Wenruo
2014-07-03 17:48 ` David Sterba
2014-07-03 9:36 ` [PATCH 3/4] btrfs-progs: Add more meaningful return value for btrfs_read_dev_super() and corresponding error string Qu Wenruo
2014-07-03 17:50 ` David Sterba
2014-07-03 9:36 ` [PATCH 4/4] btrfs-progs: Fix malloc size for superblock Qu Wenruo
2014-07-03 17:57 ` [PATCH 0/4] Add superblock checksum check for btrfs-progs David Sterba
2014-07-04 1:10 ` Qu Wenruo [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-03 9:35 Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B5FF18.7060801@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.