From: Hannes Reinecke <hare@suse.de>
To: dm-devel@redhat.com
Subject: Re: [PATCH 03/12] enable gcc format-security check
Date: Fri, 04 Jul 2014 08:18:42 +0200 [thread overview]
Message-ID: <53B64742.3030603@suse.de> (raw)
In-Reply-To: <1404105243-5071-4-git-send-email-bmarzins@redhat.com>
On 06/30/2014 07:13 AM, Benjamin Marzinski wrote:
> -Wformat-security warns about format-strigs that represent possible
> security problems. This is check is now enabled for fedora builds, and it
> seems like a reasonable thing to always be checking.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> Makefile.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.inc b/Makefile.inc
> index 0669d32..1486721 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -46,7 +46,7 @@ GZIP = gzip -9 -c
> INSTALL_PROGRAM = install
>
> ifndef RPM_OPT_FLAGS
> - RPM_OPT_FLAGS = -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
> + RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
> endif
>
> OPTFLAGS = $(RPM_OPT_FLAGS) -Wunused -Wstrict-prototypes
>
'-fstack-protector-strong' is not recognized on any of my gcc
versions supplied by SUSE. Can we please revert it to the original
'-fstack-protector'?
'-Wformat-security' is okay, though.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2014-07-04 6:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 5:13 [PATCH 00/12] miscellaneous multipath patches Benjamin Marzinski
2014-06-30 5:13 ` [PATCH 01/12] Fix memory issues in path reordering failure code paths Benjamin Marzinski
2014-07-01 18:45 ` Christophe Varoqui
2014-06-30 5:13 ` [PATCH 02/12] Return the correct size buffer in set_value() Benjamin Marzinski
2014-07-01 18:47 ` Christophe Varoqui
2014-06-30 5:13 ` [PATCH 03/12] enable gcc format-security check Benjamin Marzinski
2014-07-01 18:48 ` Christophe Varoqui
2014-07-04 6:18 ` Hannes Reinecke [this message]
2014-06-30 5:13 ` [PATCH 04/12] change conf->dry_run to conf->cmd Benjamin Marzinski
2014-07-01 18:56 ` Christophe Varoqui
2014-06-30 5:13 ` [PATCH 05/12] allow users to add wwids to /etc/multipath/wwids with -a Benjamin Marzinski
2014-07-01 18:58 ` Christophe Varoqui
2014-06-30 5:13 ` [PATCH 06/12] Make multipath add wwids from kernel cmdline mpath.wwids with -A Benjamin Marzinski
2014-07-01 19:22 ` Christophe Varoqui
2014-07-02 6:03 ` Hannes Reinecke
2014-07-02 19:48 ` Benjamin Marzinski
2014-07-03 11:05 ` Hannes Reinecke
2014-07-03 19:25 ` Benjamin Marzinski
2014-07-04 6:24 ` Hannes Reinecke
2014-07-04 7:12 ` Christophe Varoqui
2014-06-30 5:13 ` [PATCH 07/12] Make multipathd orphan paths that were removed externally Benjamin Marzinski
2014-07-24 8:41 ` Christophe Varoqui
2014-06-30 5:13 ` [PATCH 08/12] Add missing interactive commands to multipathd man page Benjamin Marzinski
2014-06-30 5:14 ` [PATCH 09/12] orphan paths on failed add Benjamin Marzinski
2014-07-24 8:45 ` Christophe Varoqui
2014-06-30 5:14 ` [PATCH 10/12] Improve multipath.conf syntax checking Benjamin Marzinski
2014-07-24 8:47 ` Christophe Varoqui
2014-06-30 5:14 ` [PATCH 11/12] make prioritizers use checker_timeout, if set Benjamin Marzinski
2014-07-24 8:49 ` Christophe Varoqui
2014-06-30 5:14 ` [PATCH 12/12] Add multipath.conf force_sync option Benjamin Marzinski
2014-07-24 8:51 ` Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B64742.3030603@suse.de \
--to=hare@suse.de \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.