From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47683)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X2xKA-0008M1-Im
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 02:50:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X2xK5-0006JI-85
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 02:50:22 -0400
Received: from cantor2.suse.de ([195.135.220.15]:56120 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X2xK5-0006J6-1R
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 02:50:17 -0400
Message-ID: <53B64EA6.9000104@suse.de>
Date: Fri, 04 Jul 2014 08:50:14 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <22b9e550138022caa0368f12c12c55f1675420a5.1403588925.git.alistair.francis@xilinx.com>
	<CAFEAcA_DTPfsWW7wykX0yPga-kibH4kf7yNYJH1sVM3p6KnifQ@mail.gmail.com>
	<53B58C08.6030206@suse.de>
In-Reply-To: <53B58C08.6030206@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 1/1] char: cadence_uart: Convert to
	realize()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Peter Maydell <peter.maydell@linaro.org>, Alistair Francis <alistair.francis@xilinx.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>


On 03.07.14 18:59, Andreas F=C3=A4rber wrote:
> Am 03.07.2014 18:46, schrieb Peter Maydell:
>> On 24 June 2014 07:06, Alistair Francis <alistair.francis@xilinx.com> =
wrote:
>>> SysBusDevice::init is deprecated. Convert to Object::init and
> Note that there is no Object::init, only TypeInfo::instance_init.
>
>>> Device::realize as prescribed by QOM conventions.
>>>
>>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>>> ---
>>>
>>>   hw/char/cadence_uart.c |   29 ++++++++++++++++-------------
>>>   1 files changed, 16 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c
>>> index bf0c853..5a22a72 100644
>>> --- a/hw/char/cadence_uart.c
>>> +++ b/hw/char/cadence_uart.c
>>> @@ -468,27 +468,30 @@ static void cadence_uart_reset(DeviceState *dev=
)
>>>       uart_update_status(s);
>>>   }
>>>
>>> -static int cadence_uart_init(SysBusDevice *dev)
>>> +static void candence_uart_realize(DeviceState *dev, Error **errp)
>> Typo in your new function name :-)
>>
>> Otherwise
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> LGTM, but I wonder whether the work Alex is doing on SysBusDevice
> requires us to introduce SysBusDevice::realize, called from
> Device::realize in SysBusDevice code?

I don't think we need a realize function with my patch set - all work=20
happens either during the creation phase (generate hint properties) or=20
in the machine, after realize has successfully passed.


Alex