From: Frederic Konrad <fred.konrad@greensocs.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, mark.burton@greensocs.com, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [RFC] icount: warp in the main_loop.
Date: Fri, 04 Jul 2014 09:30:43 +0200 [thread overview]
Message-ID: <53B65823.3050006@greensocs.com> (raw)
In-Reply-To: <1404231220-17339-1-git-send-email-fred.konrad@greensocs.com>
On 01/07/2014 18:13, fred.konrad@greensocs.com wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
>
> This fixes a bug where QEMU stall in icount mode.
>
> It happens when a simple timer callback is created on VIRTUAL CLOCK modding
> itself regularly.
>
> The actual warping mechanism is called once and then the time didn't grow
> anymore.
>
> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
> ---
> main-loop.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/main-loop.c b/main-loop.c
> index 8a85493..ef889b0 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -489,6 +489,12 @@ int main_loop_wait(int nonblocking)
>
> qemu_clock_run_all_timers();
>
> + /*
> + * In icount mode, sometimes the VCPU is blocked and an event is needed to
> + * continue.
> + * Just warp to make the time grows and have a chance to run the CPU.
> + */
> + qemu_clock_warp(QEMU_CLOCK_VIRTUAL);
> return ret;
> }
>
Paolo,
You mentioned some icount patches (I can't find where) can you point me
to them?
Did you already had this bug?
Thanks,
Fred
next prev parent reply other threads:[~2014-07-04 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 16:13 [Qemu-devel] [RFC] icount: warp in the main_loop fred.konrad
2014-07-04 7:30 ` Frederic Konrad [this message]
2014-07-04 7:57 ` Paolo Bonzini
2014-07-04 10:28 ` Frederic Konrad
2014-07-04 10:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B65823.3050006@greensocs.com \
--to=fred.konrad@greensocs.com \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.