From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2yDw-000069-Ni for qemu-devel@nongnu.org; Fri, 04 Jul 2014 03:48:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2yDq-0007Zh-Iz for qemu-devel@nongnu.org; Fri, 04 Jul 2014 03:48:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2yDq-0007ZN-BG for qemu-devel@nongnu.org; Fri, 04 Jul 2014 03:47:54 -0400 Message-ID: <53B65C1F.5030304@redhat.com> Date: Fri, 04 Jul 2014 09:47:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <53B54D98.2060800@redhat.com> <20140704025613.GC31329@G08FNSTD100614.fnst.cn.fujitsu.com> <53B62824.2010209@redhat.com> <20140704074320.GB2176@G08FNSTD100614.fnst.cn.fujitsu.com> In-Reply-To: <20140704074320.GB2176@G08FNSTD100614.fnst.cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for 2.1 2/2] memory-backend-file: improve error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , Eric Blake Cc: Yasunori Goto , Igor Mammedov , qemu-devel@nongnu.org, "Michael S. Tsirkin" Il 04/07/2014 09:43, Hu Tao ha scritto: > The memory size is rounded up to hpagesize when allocating memory, we > can waste at most hpagesize-1 bytes memory. I don't think it's a > problem. > > In the other side, do you think we should give an error in the case like > -object memory-backend-ram,size=1111M(given 2M hpagesize)? I think for gb pages it can make sense to waste a little memory (or even not so little, like if you have a 2.5 GB guest). Paolo