From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Fri, 04 Jul 2014 07:54:44 +0000 Subject: Re: [PATCH 5/6 v2] KVM: PPC: Book3E: Add ONE_REG AltiVec support Message-Id: <53B65DC4.5070001@suse.de> List-Id: References: <1404142497-6430-1-git-send-email-mihai.caraman@freescale.com> <1404142497-6430-6-git-send-email-mihai.caraman@freescale.com> <53B54DB2.1000805@suse.de> <92e31868b99a421ab578640527b41ccf@BY2PR03MB508.namprd03.prod.outlook.com> In-Reply-To: <92e31868b99a421ab578640527b41ccf@BY2PR03MB508.namprd03.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "mihai.caraman@freescale.com" , "kvm-ppc@vger.kernel.org" Cc: "kvm@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" On 03.07.14 18:11, mihai.caraman@freescale.com wrote: >> -----Original Message----- >> From: Alexander Graf [mailto:agraf@suse.de] >> Sent: Thursday, July 03, 2014 3:34 PM >> To: Caraman Mihai Claudiu-B02008; kvm-ppc@vger.kernel.org >> Cc: kvm@vger.kernel.org; linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH 5/6 v2] KVM: PPC: Book3E: Add ONE_REG AltiVec support >> >> >> On 30.06.14 17:34, Mihai Caraman wrote: >>> Add ONE_REG support for AltiVec on Book3E. >>> >>> Signed-off-by: Mihai Caraman >> Any chance we can handle these in generic code? > I expected this request :) Can we let this for a second phase to have > e6500 enabled first? I don't see the value of duplicating code in e500 specific code only to remove and combine it in common code in a follow-up patch after that. > Can you share with us a Book3S setup so I can validate the requested > changes? I already fell anxious touching strange hardware specific > Book3S code without running it. Until a few weeks ago I had an externally reachable G5 machine that we could've used for this. Unfortunately I had to replace the box with another one that's not quite as stable. I'll try and see if I can fix or replace it soon. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id D5DD81A001C for ; Fri, 4 Jul 2014 17:54:47 +1000 (EST) Message-ID: <53B65DC4.5070001@suse.de> Date: Fri, 04 Jul 2014 09:54:44 +0200 From: Alexander Graf MIME-Version: 1.0 To: "mihai.caraman@freescale.com" , "kvm-ppc@vger.kernel.org" Subject: Re: [PATCH 5/6 v2] KVM: PPC: Book3E: Add ONE_REG AltiVec support References: <1404142497-6430-1-git-send-email-mihai.caraman@freescale.com> <1404142497-6430-6-git-send-email-mihai.caraman@freescale.com> <53B54DB2.1000805@suse.de> <92e31868b99a421ab578640527b41ccf@BY2PR03MB508.namprd03.prod.outlook.com> In-Reply-To: <92e31868b99a421ab578640527b41ccf@BY2PR03MB508.namprd03.prod.outlook.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: "linuxppc-dev@lists.ozlabs.org" , "kvm@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03.07.14 18:11, mihai.caraman@freescale.com wrote: >> -----Original Message----- >> From: Alexander Graf [mailto:agraf@suse.de] >> Sent: Thursday, July 03, 2014 3:34 PM >> To: Caraman Mihai Claudiu-B02008; kvm-ppc@vger.kernel.org >> Cc: kvm@vger.kernel.org; linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH 5/6 v2] KVM: PPC: Book3E: Add ONE_REG AltiVec support >> >> >> On 30.06.14 17:34, Mihai Caraman wrote: >>> Add ONE_REG support for AltiVec on Book3E. >>> >>> Signed-off-by: Mihai Caraman >> Any chance we can handle these in generic code? > I expected this request :) Can we let this for a second phase to have > e6500 enabled first? I don't see the value of duplicating code in e500 specific code only to remove and combine it in common code in a follow-up patch after that. > Can you share with us a Book3S setup so I can validate the requested > changes? I already fell anxious touching strange hardware specific > Book3S code without running it. Until a few weeks ago I had an externally reachable G5 machine that we could've used for this. Unfortunately I had to replace the box with another one that's not quite as stable. I'll try and see if I can fix or replace it soon. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH 5/6 v2] KVM: PPC: Book3E: Add ONE_REG AltiVec support Date: Fri, 04 Jul 2014 09:54:44 +0200 Message-ID: <53B65DC4.5070001@suse.de> References: <1404142497-6430-1-git-send-email-mihai.caraman@freescale.com> <1404142497-6430-6-git-send-email-mihai.caraman@freescale.com> <53B54DB2.1000805@suse.de> <92e31868b99a421ab578640527b41ccf@BY2PR03MB508.namprd03.prod.outlook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" To: "mihai.caraman@freescale.com" , "kvm-ppc@vger.kernel.org" Return-path: Received: from cantor2.suse.de ([195.135.220.15]:48732 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753373AbaGDHyq (ORCPT ); Fri, 4 Jul 2014 03:54:46 -0400 In-Reply-To: <92e31868b99a421ab578640527b41ccf@BY2PR03MB508.namprd03.prod.outlook.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03.07.14 18:11, mihai.caraman@freescale.com wrote: >> -----Original Message----- >> From: Alexander Graf [mailto:agraf@suse.de] >> Sent: Thursday, July 03, 2014 3:34 PM >> To: Caraman Mihai Claudiu-B02008; kvm-ppc@vger.kernel.org >> Cc: kvm@vger.kernel.org; linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH 5/6 v2] KVM: PPC: Book3E: Add ONE_REG AltiVec support >> >> >> On 30.06.14 17:34, Mihai Caraman wrote: >>> Add ONE_REG support for AltiVec on Book3E. >>> >>> Signed-off-by: Mihai Caraman >> Any chance we can handle these in generic code? > I expected this request :) Can we let this for a second phase to have > e6500 enabled first? I don't see the value of duplicating code in e500 specific code only to remove and combine it in common code in a follow-up patch after that. > Can you share with us a Book3S setup so I can validate the requested > changes? I already fell anxious touching strange hardware specific > Book3S code without running it. Until a few weeks ago I had an externally reachable G5 machine that we could've used for this. Unfortunately I had to replace the box with another one that's not quite as stable. I'll try and see if I can fix or replace it soon. Alex