From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] ARM: dts: Add I2S dt node for Exynos3250 Date: Fri, 04 Jul 2014 10:05:58 +0200 Message-ID: <53B66066.4030202@gmail.com> References: <1404373939-10510-1-git-send-email-cw00.choi@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404373939-10510-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Chanwoo Choi , linux@arm.linux.org.uk, kgene.kim@samsung.com, t.figa@samsung.com Cc: kyungmin.park@samsung.com, ideal.song@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org Hi Chanwoo, On 03.07.2014 09:52, Chanwoo Choi wrote: > From: Tomasz Figa > > This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo > (1 channels) IIS-bus for audio interface with DMA-based operation. > > Signed-off-by: Tomasz Figa > Signed-off-by: Inha Song > Tested-by: Inha Song > Signed-off-by: Chanwoo Choi > Acked-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 1f8384f..e9017ef 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -644,6 +644,19 @@ > status = "disabled"; > }; > > + i2s: i2s@13970000 { Shouldn't the label be rather called "i2s2" as the pinctrl entry below suggests? > + compatible = "samsung,s3c6410-i2s"; > + reg = <0x13970000 0x100>; > + interrupts = <0 126 0>; > + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; > + clock-names = "iis", "i2s_opclk0"; > + dmas = <&pdma0 14>, <&pdma0 13>; > + dma-names = "tx", "rx"; > + pinctrl-0 = <&i2s2_bus>; > + pinctrl-name = "default"; "pinctrl-name" is not a valid property. I suppose it should be "pinctrl-names". Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Fri, 04 Jul 2014 10:05:58 +0200 Subject: [PATCH] ARM: dts: Add I2S dt node for Exynos3250 In-Reply-To: <1404373939-10510-1-git-send-email-cw00.choi@samsung.com> References: <1404373939-10510-1-git-send-email-cw00.choi@samsung.com> Message-ID: <53B66066.4030202@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chanwoo, On 03.07.2014 09:52, Chanwoo Choi wrote: > From: Tomasz Figa > > This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo > (1 channels) IIS-bus for audio interface with DMA-based operation. > > Signed-off-by: Tomasz Figa > Signed-off-by: Inha Song > Tested-by: Inha Song > Signed-off-by: Chanwoo Choi > Acked-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 1f8384f..e9017ef 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -644,6 +644,19 @@ > status = "disabled"; > }; > > + i2s: i2s at 13970000 { Shouldn't the label be rather called "i2s2" as the pinctrl entry below suggests? > + compatible = "samsung,s3c6410-i2s"; > + reg = <0x13970000 0x100>; > + interrupts = <0 126 0>; > + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; > + clock-names = "iis", "i2s_opclk0"; > + dmas = <&pdma0 14>, <&pdma0 13>; > + dma-names = "tx", "rx"; > + pinctrl-0 = <&i2s2_bus>; > + pinctrl-name = "default"; "pinctrl-name" is not a valid property. I suppose it should be "pinctrl-names". Best regards, Tomasz