From: Julien Grall <julien.grall@linaro.org>
To: Vijay Kilari <vijay.kilari@gmail.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>,
Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>,
Tim Deegan <tim@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>
Subject: Re: [PATCH v8a 5/6] xen/arm: split vgic driver into generic and vgic-v2 driver
Date: Fri, 04 Jul 2014 11:20:37 +0100 [thread overview]
Message-ID: <53B67FF5.2080206@linaro.org> (raw)
In-Reply-To: <CALicx6uchJ257aPv_aRF-TgHYmeeQHk3qs8W2J88f-yDQppN5Q@mail.gmail.com>
On 07/04/2014 08:01 AM, Vijay Kilari wrote:
>>> where vgic_emulate is implemented in vgic-v3.c rather than in vgic.c.
>>> The function will decode the register and then call vgic_send_sgi.
>
> The reason why vgic_emulate is kept in vgic-v3.c is because it is
> GICv3 specific
> and also the traps are landing in respective drivers. Ex: for GICv2
> write to GICD_SGIR
> is trapped in vgic-v2.c and similarly I expect for GICv3 is should be
> kept in GICv3.
Even though it's vGICv3 specific, vGICv2 will be handled sooner or later
on GICv3 platform.
Directly implement vgic_emulate in vgic-v3.c won't help to catch coding
error from Xen and may bring the hypervisor to segfault.
It could be the case if we forgot to disable system register trapping
(which I don't think you do) in the GICv3.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-04 10:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 8:34 [PATCH v8a 0/6] GIC and VGIC code refactoring vijay.kilari
2014-07-03 8:34 ` [PATCH v8a 1/6] xen/arm: move and rename is_vcpu_running function to sched.h vijay.kilari
2014-07-03 9:12 ` Jan Beulich
2014-07-03 9:23 ` Ian Campbell
2014-07-03 12:49 ` Julien Grall
2014-07-03 13:24 ` Jan Beulich
2014-07-03 8:34 ` [PATCH v8a 2/6] xen/arm: move pending_irq structure to vgic header file vijay.kilari
2014-07-03 8:34 ` [PATCH v8a 3/6] xen/arm: calculate vgic irq rank based on register size vijay.kilari
2014-07-03 8:34 ` [PATCH v8a 4/6] xen/arm: Remove REG macro in vgic driver vijay.kilari
2014-07-03 8:34 ` [PATCH v8a 5/6] xen/arm: split vgic driver into generic and vgic-v2 driver vijay.kilari
2014-07-03 12:57 ` Julien Grall
2014-07-03 13:02 ` Ian Campbell
2014-07-03 13:25 ` Julien Grall
2014-07-03 14:02 ` Ian Campbell
2014-07-03 14:21 ` Julien Grall
2014-07-03 15:18 ` Ian Campbell
2014-07-04 7:01 ` Vijay Kilari
2014-07-04 10:20 ` Julien Grall [this message]
2014-07-03 8:34 ` [PATCH v8a 6/6] xen/arm: Restrict saving of gic register for idle domain vijay.kilari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B67FF5.2080206@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=vijaya.kumar@caviumnetworks.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.