From: David Vrabel <david.vrabel@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Marek Marczykowski <marmarek@invisiblethingslab.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] xen/balloon: set ballooned out pages as invalid in p2m
Date: Fri, 4 Jul 2014 15:18:13 +0100 [thread overview]
Message-ID: <53B6B7A5.70603@citrix.com> (raw)
In-Reply-To: <1404294054-22691-1-git-send-email-david.vrabel@citrix.com>
On 02/07/14 10:40, David Vrabel wrote:
> Since cd9151e26d31048b2b5e00fd02e110e07d2200c9 (xen/balloon: set a
> mapping for ballooned out pages), a ballooned out page had its entry
> in the p2m set to the MFN of one of the scratch pages. This means
> that the p2m will contain many entries pointing to the same MFN.
>
> During a domain save, these many-to-one entries are not identified as
> such and the scratch page is saved multiple times. On restore the
> ballooned pages are populated with new frames and the domain may use
> up its allocation before all pages can be restored.
>
> Since the original fix only needed to keep a mapping for the ballooned
> page it is safe to set ballooned out pages as INVALID_P2M_ENTRY in the
> p2m (as they were before). Thus preventing them from being saved and
> re-populated on restore.
Stefano acked v1 so I've applied to to stable/for-linus-2.16 and tagged
for stable.
David
next prev parent reply other threads:[~2014-07-04 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 9:40 [PATCH] xen/balloon: set ballooned out pages as invalid in p2m David Vrabel
2014-07-04 14:18 ` David Vrabel [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-01 13:37 David Vrabel
2014-07-01 13:58 ` Konrad Rzeszutek Wilk
2014-07-01 14:00 ` David Vrabel
2014-07-01 14:06 ` Konrad Rzeszutek Wilk
2014-07-04 14:08 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B6B7A5.70603@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=marmarek@invisiblethingslab.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.