All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@samsung.com>, linux-iio@vger.kernel.org
Cc: spk.linux@gmail.com,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH 7/7] iio: hid-sensors: Fix compilation warning
Date: Sat, 05 Jul 2014 11:21:25 +0100	[thread overview]
Message-ID: <53B7D1A5.4050102@kernel.org> (raw)
In-Reply-To: <1404369852-3255-7-git-send-email-sachin.kamat@samsung.com>

On 03/07/14 07:44, Sachin Kamat wrote:
> Move the 'static' keyword to beginning of definition to silence the
> following compilation warning:
> drivers/iio/common/hid-sensors/hid-sensor-attributes.c:34:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the togreg branch of iio.git

Thanks,


> ---
>   .../iio/common/hid-sensors/hid-sensor-attributes.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> index 403dd3d..1614340 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> @@ -26,12 +26,12 @@
>   #include <linux/iio/iio.h>
>   #include <linux/iio/sysfs.h>
>
> -struct {
> +static struct {
>   	u32 usage_id;
>   	int unit; /* 0 for default others from HID sensor spec */
>   	int scale_val0; /* scale, whole number */
>   	int scale_val1; /* scale, fraction in micros */
> -} static unit_conversion[] = {
> +} unit_conversion[] = {
>   	{HID_USAGE_SENSOR_ACCEL_3D, 0, 9, 806650},
>   	{HID_USAGE_SENSOR_ACCEL_3D,
>   		HID_USAGE_SENSOR_UNITS_METERS_PER_SEC_SQRD, 1, 0},
>


  reply	other threads:[~2014-07-05 10:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03  6:44 [PATCH 1/7] iio: hid-sensor-press: Fix return values Sachin Kamat
2014-07-03  6:44 ` [PATCH 2/7] iio: hid-sensor-accel-3d: " Sachin Kamat
2014-07-05 10:09   ` Jonathan Cameron
2014-07-03  6:44 ` [PATCH 3/7] iio: hid-sensor-magn-3d: " Sachin Kamat
2014-07-05 10:09   ` Jonathan Cameron
2014-07-03  6:44 ` [PATCH 4/7] iio: hid-sensor-als: " Sachin Kamat
2014-07-05 10:10   ` Jonathan Cameron
2014-07-03  6:44 ` [PATCH 5/7] iio: hid-sensor-gyro-3d: " Sachin Kamat
2014-07-05 10:10   ` Jonathan Cameron
2014-07-03  6:44 ` [PATCH 6/7] iio: hid-sensor-prox: " Sachin Kamat
2014-07-05 10:11   ` Jonathan Cameron
2014-07-03  6:44 ` [PATCH 7/7] iio: hid-sensors: Fix compilation warning Sachin Kamat
2014-07-05 10:21   ` Jonathan Cameron [this message]
2014-07-03 23:01 ` [PATCH 1/7] iio: hid-sensor-press: Fix return values Srinivas Pandruvada
2014-07-04  5:51   ` Jonathan Cameron
2014-07-05 10:08 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B7D1A5.4050102@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=sachin.kamat@samsung.com \
    --cc=spk.linux@gmail.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.