All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs: Add INCLUDES to BUILD_CFLAGS when cross-compiling
Date: Sat, 05 Jul 2014 21:32:40 -0300	[thread overview]
Message-ID: <53B89928.3010206@zacarias.com.ar> (raw)
In-Reply-To: <20140705235542.GA19036@thunk.org>

On 07/05/2014 08:55 PM, Theodore Ts'o wrote:

> I would think that
> 
> BUILD_CFLAGS="-I$(top_builddir)/lib -DHAVE_CONFIG_H"
> 
> ... would be safer, since $INCLUDES could potentially include some
> $CPPFLAGS that could be specific to the target architecture.
> 
> Yes?

Not really, since that way it's missing config.h, still failing:

-----
cd ./util ; /usr/bin/make subst
make[2]: Entering directory
`/home/gustavoz/b/test/output/build/e2fsprogs-1.42.10/util'
        CREATE dirpaths.h
        CC subst.c
subst.c:8:20: fatal error: config.h: No such file or directory
compilation terminated.
-----

Regards.

      reply	other threads:[~2014-07-06  0:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 21:51 [PATCH] e2fsprogs: Add INCLUDES to BUILD_CFLAGS when cross-compiling Gustavo Zacarias
2014-07-05 23:55 ` Theodore Ts'o
2014-07-06  0:32   ` Gustavo Zacarias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B89928.3010206@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.