All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Austin Schuh <austin@peloton-tech.com>
Cc: linux-can@vger.kernel.org
Subject: Re: skbuff panic
Date: Sun, 06 Jul 2014 18:13:12 +0200	[thread overview]
Message-ID: <53B97598.50400@hartkopp.net> (raw)
In-Reply-To: <53B93D45.5090505@hartkopp.net>

Answering myself:

I tested the latest 3.16.0-rc3-00149-g034a0f6 with tst-packet.c and it works
like charm. Receiving and sending with tst-packet is no problem.
I was using the SJA1000 based EMS PCMCIA card in my laptop for this test.

So I really wonder why (obviously) a CAN frame is processed by the PF_PACKET
reception handler at the start of your system?!?

Regards,
Oliver

On 06.07.2014 14:12, Oliver Hartkopp wrote:
> On 06.07.2014 07:07, Austin Schuh wrote:
> 
>> What makes you think that someone opened a PF_PACKET socket?  I'm
>> curious, since that observation may help me produce a more reliable
>> test case and debug it some more myself.
> 
> If you look in your call trace is says:
> 
> skb_push+0x38/0x39          (-->> which panics)
> packet_rcv_spkt+0x98/0xdf
> __netif_receive_skb_core+0x459/0x4dc
> get_parent_ip+0xe/0x3e
> __netif_receive_skb+0x53/0x65
> 
> As packet_rcv_spkt() is located in net/packet/af_packet.c there must be some
> user at this early stage of system boot to make PF_PACKET process the CAN frame.
> 
> In https://gitorious.org/linux-can/can-tests there's a tst-packet.c program
> which uses the PF_PACKET socket to send/receive CAN frames.
> 
> I was using tst-packet.c about four years ago for a test - without any
> problems. But maybe something in the network layer changed, so that CAN frame
> skbs need to be created with a different setup now.
> 
> I'll try ASAP if tst-packet.c still works as expected on my machine.
> 
>>
>> I'm going to work on reproducing the panic more reliable, and then
>> I'll give your patch a whirl.  Currently, only PCs that are on the
>> other end of cell modems out in the field seem to be triggering the
>> panic.  I'm hesitant to do excessive experimentation on something that
>> takes a plane trip to fix.  That just means that this will take longer
>> to debug that I'd like...
> 
> Indeed this should not be the plan ...
> Let's save the world by saving carbon dioxide ;-)
> 
> Best regards,
> Oliver
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2014-07-06 16:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03 23:03 skbuff panic Austin Schuh
2014-07-03 23:18 ` Austin Schuh
2014-07-05 10:40 ` Oliver Hartkopp
2014-07-05 18:38   ` Austin Schuh
2014-07-05 19:21     ` Oliver Hartkopp
2014-07-06  5:07       ` Austin Schuh
2014-07-06 12:12         ` Oliver Hartkopp
2014-07-06 16:13           ` Oliver Hartkopp [this message]
2014-07-06 19:38             ` Marc Kleine-Budde
2014-07-07  4:11               ` Austin Schuh
2014-07-10  0:07                 ` Austin Schuh
2014-07-10 17:37                   ` Austin Schuh
2014-07-11 13:27                     ` Oliver Hartkopp
2014-07-11 14:58                       ` Austin Schuh
2014-07-11 17:48                         ` Marc Kleine-Budde
2015-02-19 11:48                           ` Daniel Steer
2015-02-23 12:55                             ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B97598.50400@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=austin@peloton-tech.com \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.