All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Manish Badarkhe <badarkhe.manish@gmail.com>,
	linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Cc: broonie@kernel.org
Subject: Re: [PATCH] ASoC: omap-mcbsp: Use devm_snd_soc_register_component
Date: Mon, 7 Jul 2014 12:29:25 +0300	[thread overview]
Message-ID: <53BA6875.8060309@ti.com> (raw)
In-Reply-To: <1404536979-5318-1-git-send-email-badarkhe.manish@gmail.com>

On 07/05/2014 08:09 AM, Manish Badarkhe wrote:
> Replaced snd_soc_register_component with its devres equivalent,
> devm_snd_soc_register_component.
> 
> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
> ---
> :100644 100644 efe2cd6... bfc8f8e... M	sound/soc/omap/omap-mcbsp.c
>  sound/soc/omap/omap-mcbsp.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
> index efe2cd6..bfc8f8e 100644
> --- a/sound/soc/omap/omap-mcbsp.c
> +++ b/sound/soc/omap/omap-mcbsp.c
> @@ -805,7 +805,7 @@ static int asoc_mcbsp_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	ret = snd_soc_register_component(&pdev->dev, &omap_mcbsp_component,
> +	ret = devm_snd_soc_register_component(&pdev->dev, &omap_mcbsp_component,
>  					 &omap_mcbsp_dai, 1);

Can you align the parameters as well?

>  	if (ret)
>  		return ret;
> @@ -817,8 +817,6 @@ static int asoc_mcbsp_remove(struct platform_device *pdev)
>  {
>  	struct omap_mcbsp *mcbsp = platform_get_drvdata(pdev);
>  
> -	snd_soc_unregister_component(&pdev->dev);
> -
>  	if (mcbsp->pdata->ops && mcbsp->pdata->ops->free)
>  		mcbsp->pdata->ops->free(mcbsp->id);
>  
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2014-07-07  9:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-05  5:09 [PATCH] ASoC: omap-mcbsp: Use devm_snd_soc_register_component Manish Badarkhe
2014-07-07  9:29 ` Peter Ujfalusi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BA6875.8060309@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=badarkhe.manish@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.