Re: [PATCH] ASoC: omap-hdmi: Use devm_snd_soc_register_component

[Peter Ujfalusi <peter.ujfalusi@ti.com>]

On 07/06/2014 09:49 AM, Manish Badarkhe wrote:
> Replaced snd_soc_register_component with its devres equivalent,
> devm_snd_soc_register_component.
> 
> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
> ---
> :100644 100644 eb9c392... 1dc95b5... M	sound/soc/omap/omap-hdmi.c
>  sound/soc/omap/omap-hdmi.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c
> index eb9c392..1dc95b5 100644
> --- a/sound/soc/omap/omap-hdmi.c
> +++ b/sound/soc/omap/omap-hdmi.c
> @@ -322,7 +322,7 @@ static int omap_hdmi_probe(struct platform_device *pdev)
>  	}
>  
>  	dev_set_drvdata(&pdev->dev, hdmi_data);
> -	ret = snd_soc_register_component(&pdev->dev, &omap_hdmi_component,
> +	ret = devm_snd_soc_register_component(&pdev->dev, &omap_hdmi_component,
>  					 &omap_hdmi_dai, 1);

As with the omap-mcbsp:
Can you align the parameters as well?

>  
>  	if (ret)
> @@ -335,8 +335,6 @@ static int omap_hdmi_remove(struct platform_device *pdev)
>  {
>  	struct hdmi_priv *hdmi_data = dev_get_drvdata(&pdev->dev);
>  
> -	snd_soc_unregister_component(&pdev->dev);
> -
>  	if (hdmi_data == NULL) {
>  		dev_err(&pdev->dev, "cannot obtain HDMi data\n");
>  		return -ENODEV;
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html