From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Manish Badarkhe <badarkhe.manish@gmail.com>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Cc: broonie@kernel.org
Subject: Re: [PATCH] ASoC: omap-dmic: Use devm_snd_soc_register_component
Date: Mon, 7 Jul 2014 12:30:25 +0300 [thread overview]
Message-ID: <53BA68B1.5040309@ti.com> (raw)
In-Reply-To: <1404629414-3263-1-git-send-email-badarkhe.manish@gmail.com>
On 07/06/2014 09:50 AM, Manish Badarkhe wrote:
> Replaced snd_soc_register_component with its devres equivalent,
> devm_snd_soc_register_component.
>
> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
> ---
> :100644 100644 6925d71... 011e30e... M sound/soc/omap/omap-dmic.c
> sound/soc/omap/omap-dmic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
> index 6925d71..011e30e 100644
> --- a/sound/soc/omap/omap-dmic.c
> +++ b/sound/soc/omap/omap-dmic.c
> @@ -490,7 +490,7 @@ static int asoc_dmic_probe(struct platform_device *pdev)
> }
>
>
> - ret = snd_soc_register_component(&pdev->dev, &omap_dmic_component,
> + ret = devm_snd_soc_register_component(&pdev->dev, &omap_dmic_component,
> &omap_dmic_dai, 1);
Would you align the parameters at the same time?
> if (ret)
> goto err_put_clk;
> @@ -510,7 +510,6 @@ static int asoc_dmic_remove(struct platform_device *pdev)
> {
> struct omap_dmic *dmic = platform_get_drvdata(pdev);
>
> - snd_soc_unregister_component(&pdev->dev);
> clk_put(dmic->fclk);
>
> return 0;
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-07 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 6:50 [PATCH] ASoC: omap-dmic: Use devm_snd_soc_register_component Manish Badarkhe
2014-07-07 9:30 ` Peter Ujfalusi [this message]
2014-07-08 11:48 ` Manish Badarkhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA68B1.5040309@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=badarkhe.manish@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.