From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: srinivas.pandruvada@linux.intel.com,
archana.patni@linux.intel.com, subramony.sesha@intel.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: hid-sensors: make hid_sensor_get_reporting_interval static
Date: Mon, 07 Jul 2014 13:30:18 +0100 [thread overview]
Message-ID: <53BA92DA.7070304@kernel.org> (raw)
In-Reply-To: <1404120584-11795-1-git-send-email-daniel.baluta@intel.com>
On 30/06/14 10:29, Daniel Baluta wrote:
> This fixes the following sparse warning:
>
> CHECK drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> drivers/iio/common/hid-sensors/hid-sensor-attributes.c:346:5: warning:
> symbol 'hid_sensor_get_reporting_interval' was not declared. Should it be static?
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied to the togreg branch of iio.git, initially pushed out as testing
for the autobuilders to play. Thanks,
Jonathan
> ---
> drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> index 403dd3d..8220df1 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> @@ -343,6 +343,7 @@ int hid_sensor_format_scale(u32 usage_id,
> }
> EXPORT_SYMBOL(hid_sensor_format_scale);
>
> +static
> int hid_sensor_get_reporting_interval(struct hid_sensor_hub_device *hsdev,
> u32 usage_id,
> struct hid_sensor_common *st)
>
prev parent reply other threads:[~2014-07-07 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 9:29 [PATCH] iio: hid-sensors: make hid_sensor_get_reporting_interval static Daniel Baluta
2014-07-07 12:30 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA92DA.7070304@kernel.org \
--to=jic23@kernel.org \
--cc=archana.patni@linux.intel.com \
--cc=daniel.baluta@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=subramony.sesha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.