From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@samsung.com>, linux-iio@vger.kernel.org
Cc: gregkh@linuxfoundation.org, spk.linux@gmail.com,
Michael Hennerich <hennerich@blackfin.uclinux.org>
Subject: Re: [PATCH 1/1] staging: iio: ad9832: Remove redundant check
Date: Mon, 07 Jul 2014 13:32:22 +0100 [thread overview]
Message-ID: <53BA9356.8070303@kernel.org> (raw)
In-Reply-To: <1404388568-5370-1-git-send-email-sachin.kamat@samsung.com>
On 03/07/14 12:56, Sachin Kamat wrote:
> 'val' is unsigned and cannot be negative.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>
Applied to the togreg branch of iio.git
Thanks
> ---
> drivers/staging/iio/frequency/ad9832.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index b7c8351..cf68159 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -120,7 +120,7 @@ static ssize_t ad9832_write(struct device *dev, struct device_attribute *attr,
> ret = spi_sync(st->spi, &st->msg);
> break;
> case AD9832_PHASE_SYM:
> - if (val < 0 || val > 3) {
> + if (val > 3) {
> ret = -EINVAL;
> break;
> }
>
prev parent reply other threads:[~2014-07-07 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 11:56 [PATCH 1/1] staging: iio: ad9832: Remove redundant check Sachin Kamat
2014-07-07 12:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA9356.8070303@kernel.org \
--to=jic23@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hennerich@blackfin.uclinux.org \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@samsung.com \
--cc=spk.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.