From: Hans de Goede <hdegoede@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
linux-scsi@vger.kernel.org
Subject: Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|
Date: Mon, 07 Jul 2014 14:42:40 +0200 [thread overview]
Message-ID: <53BA95C0.3020607@redhat.com> (raw)
In-Reply-To: <20140707101015.GB3544@infradead.org>
Hi,
On 07/07/2014 12:10 PM, Christoph Hellwig wrote:
> On Sun, Jul 06, 2014 at 02:24:03PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 07/03/2014 08:01 AM, Christoph Hellwig wrote:
>>> Hi Hans,
>>>
>>> please test the path below:
>>
>> Note, I did a similar patch a while back, but then it was decided to
>> try and fix the tear-down ordering instead (which seems to have not
>> completely fixed the issue).
>
> I can't see any sensible way to "fix" the issue. Struct gendisk keeps a
> reference to the requeue_queue, and a struct gendisk reference is held
> as long as the block device is open. So whenever you surprise remove a
> device that is open (usually by having a filesystem mounted on it),
> the request_queue and it's reference to the tag structure will vastly
> outlive the Scsi_Host.
Ok, so can we then please move forward with getting your patch merged ?
Thanks,
Hans
next prev parent reply other threads:[~2014-07-07 12:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 13:16 uas: kernel BUG at block/blk-tag.c:89 is back again :| Hans de Goede
2014-07-03 6:01 ` Christoph Hellwig
2014-07-06 12:24 ` Hans de Goede
2014-07-07 10:10 ` Christoph Hellwig
2014-07-07 12:42 ` Hans de Goede [this message]
2014-07-08 9:53 ` Christoph Hellwig
2014-07-08 9:54 ` Jens Axboe
2014-07-08 9:56 ` Christoph Hellwig
2014-07-08 10:35 ` Jens Axboe
2014-07-08 11:25 ` Hans de Goede
2014-07-08 11:40 ` Jens Axboe
2014-07-21 8:15 ` Hans de Goede
2014-07-21 8:17 ` Jens Axboe
2014-07-21 9:10 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA95C0.3020607@redhat.com \
--to=hdegoede@redhat.com \
--cc=JBottomley@parallels.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.