From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v3 4/6] xen/PMU: Describe vendor-specific PMU registers Date: Mon, 07 Jul 2014 10:13:46 -0400 Message-ID: <53BAAB1A.5040404@oracle.com> References: <1404414899-1773-1-git-send-email-boris.ostrovsky@oracle.com> <1404414899-1773-5-git-send-email-boris.ostrovsky@oracle.com> <53B684E1.2050106@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53B684E1.2050106@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , konrad.wilk@oracle.com Cc: andrew.cooper3@citrix.com, kevin.tian@intel.com, dietmar.hahn@ts.fujitsu.com, jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/04/2014 06:41 AM, David Vrabel wrote: > On 03/07/14 20:14, Boris Ostrovsky wrote: >> AMD and Intel PMU register initialization and helpers that determine whether a >> register belongs to PMU. >> >> This and some of subsequent PMU emulation code is somewhat similar to Xen's PMU >> implementation. >> > I trust that the hardware bit are correct. > > Reviewed-by: David Vrabel > > Although I wonder if a lookup table might be better than the chain of ifs. I'll see if I can do that (while keeping code readable). -boris (Thanks for strim pointer, I didn't know we had one)