From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Subject: Re: [PATCH V5] x86,
 amd_ucode: Support multiple container files appended together
Date: Mon, 7 Jul 2014 10:37:19 -0500
Message-ID: <53BABEAF.1010307@amd.com>
References: <1404402440-339-1-git-send-email-aravind.gopalakrishnan@amd.com>
	<53B69C860200007800020A2A@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53B69C860200007800020A2A@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: boris.ostrovsky@oracle.com, keir@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 7/4/2014 5:22 AM, Jan Beulich wrote:
>>>> On 03.07.14 at 17:47, <aravind.gopalakrishnan@amd.com> wrote:
>> @@ -236,7 +251,14 @@ static int get_ucode_from_buffer_amd(
>>       mpbuf = (const struct mpbhdr *)&bufp[off];
>>       if ( mpbuf->type != UCODE_UCODE_TYPE )
>>       {
>> -        printk(KERN_ERR "microcode: Wrong microcode payload type field\n");
>> +        /*
>> +         * In a situation where ucode update has succeeded;
>> +         * but there is a subsequent container file being parsed,
>> +         * then, there is no need of this ERR message to be printed.
>> +         */
>> +        if ( *(const uint32_t *)buf != UCODE_MAGIC )
> Don't you need to use mpbuf here (which is equal to buf only when
> off == 0)?
Hmm. Actually, this check here can be removed as well;
after the changes in V5, we won't really hit this condition anyway.

Thanks,
-Aravind.