All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Denis CIOCCA <denis.ciocca@st.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [RESEND PATCH 3/3] iio: st_sensors: add devicetree probing support
Date: Mon, 07 Jul 2014 17:17:44 +0100	[thread overview]
Message-ID: <53BAC828.7020602@kernel.org> (raw)
In-Reply-To: <CACRpkdYCh7qQM7C1WpphNyhi96NkYEP8chXOtQP3YdyuprmptA@mail.gmail.com>

On 07/07/14 14:54, Linus Walleij wrote:
> On Mon, Jul 7, 2014 at 2:24 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>
>> ERROR: "st_sensors_of_i2c_probe" [drivers/iio/pressure/st_pressure_i2c.ko]
>> undefined!
>> ERROR: "st_sensors_of_i2c_probe" [drivers/iio/magnetometer/st_magn_i2c.ko]
>> undefined!
>> ERROR: "st_sensors_of_i2c_probe" [drivers/iio/gyro/st_gyro_i2c.ko]
>> undefined!
>> ERROR: "st_sensors_of_i2c_probe" [drivers/iio/accel/st_accel_i2c.ko]
>> undefined!
>> scripts/Makefile.modpost:90: recipe for target '__modpost' failed
>> make[1]: *** [__modpost] Error 1
>> Makefile:1047: recipe for target 'modules' failed
>> make: *** [modules] Error 2
>>
>> When CONFIG_OF not selected.
>
> Um, when CONFIG_OF is *not* selected?
>
> This looks more like it is selected, but the symbol is missing, since
> I missed to export that symbol, right?
*coughs* Yup you are right of course.  The build in question did indeed
have CONFIG_OF selected.
>
> In the !CONFIG_OF case there is a static inline in
> <linux/iio/common/st_sensors_i2c.h> to handle that.
>
> The v2 patch I just sent should fix this issue...
Cool.
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


      reply	other threads:[~2014-07-07 16:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07  9:48 [RESEND PATCH 3/3] iio: st_sensors: add devicetree probing support Linus Walleij
2014-07-07 12:24 ` Jonathan Cameron
2014-07-07 13:54   ` Linus Walleij
2014-07-07 16:17     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BAC828.7020602@kernel.org \
    --to=jic23@kernel.org \
    --cc=denis.ciocca@st.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.