Re: [PATCH] rbd: do not leak image_id in rbd_dev_v2_parent_info()

[Alex Elder <elder@ieee.org>]

On 06/30/2014 04:45 AM, Ilya Dryomov wrote:
> image_id is leaked if the parent happens to have been recorded already.
> Fix it.

Looks good.

Reviewed-by: Alex Elder <elder@linaro.org>

> 
> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
> ---
>  drivers/block/rbd.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index d99aa81774f8..adedb393b374 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -4072,6 +4072,8 @@ static int rbd_dev_v2_parent_info(struct rbd_device *rbd_dev)
>  		parent_spec->snap_id = snap_id;
>  		rbd_dev->parent_spec = parent_spec;
>  		parent_spec = NULL;	/* rbd_dev now owns this */
> +	} else {
> +		kfree(image_id);
>  	}
>  
>  	/*
>