From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.active-venture.com ([67.228.131.205]:60702 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754162AbaGHBMZ (ORCPT ); Mon, 7 Jul 2014 21:12:25 -0400 Message-ID: <53BB4577.3020601@roeck-us.net> Date: Mon, 07 Jul 2014 18:12:23 -0700 From: Guenter Roeck MIME-Version: 1.0 To: Andrew Morton CC: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Wim Van Sebroeck , Catalin Marinas , Maxime Ripard , Will Deacon , Arnd Bergmann , Heiko Stuebner , Russell King , Jonas Jensen , Randy Dunlap , Steven Rostedt , Ingo Molnar , Dmitry Eremin-Solenikov , David Woodhouse , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] arm64: Support restart through restart notifier call chain References: <1404689900-27421-1-git-send-email-linux@roeck-us.net> <1404689900-27421-3-git-send-email-linux@roeck-us.net> <20140707141654.d7fb9f8839cdf58822cd43b9@linux-foundation.org> In-Reply-To: <20140707141654.d7fb9f8839cdf58822cd43b9@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 07/07/2014 02:16 PM, Andrew Morton wrote: > On Sun, 6 Jul 2014 16:38:15 -0700 Guenter Roeck wrote: > >> The kernel core now supports a notifier call chain to restart >> the system. Call it if arm_pm_restart is not set. >> >> ... >> >> --- a/arch/arm64/kernel/process.c >> +++ b/arch/arm64/kernel/process.c >> @@ -174,6 +174,9 @@ void machine_restart(char *cmd) >> /* Now call the architecture specific reboot code. */ >> if (arm_pm_restart) >> arm_pm_restart(reboot_mode, cmd); >> + else >> + blocking_notifier_call_chain(&restart_notifier_list, >> + reboot_mode, cmd); > > It would be a bit neater to have a helper function to perform the call, > rather than directly accessing the notifier list. Apart from anything > else, this hides the fact that the core code (presently!) uses the > blocking_ style notifiers. > Introduced kernel_restart_notify (proposals for better names welcome). As a side effect, moved restart_notifier_list into kernel/reboot.c and made it static. Thanks, Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Mon, 07 Jul 2014 18:12:23 -0700 Subject: [PATCH v2 2/7] arm64: Support restart through restart notifier call chain In-Reply-To: <20140707141654.d7fb9f8839cdf58822cd43b9@linux-foundation.org> References: <1404689900-27421-1-git-send-email-linux@roeck-us.net> <1404689900-27421-3-git-send-email-linux@roeck-us.net> <20140707141654.d7fb9f8839cdf58822cd43b9@linux-foundation.org> Message-ID: <53BB4577.3020601@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/07/2014 02:16 PM, Andrew Morton wrote: > On Sun, 6 Jul 2014 16:38:15 -0700 Guenter Roeck wrote: > >> The kernel core now supports a notifier call chain to restart >> the system. Call it if arm_pm_restart is not set. >> >> ... >> >> --- a/arch/arm64/kernel/process.c >> +++ b/arch/arm64/kernel/process.c >> @@ -174,6 +174,9 @@ void machine_restart(char *cmd) >> /* Now call the architecture specific reboot code. */ >> if (arm_pm_restart) >> arm_pm_restart(reboot_mode, cmd); >> + else >> + blocking_notifier_call_chain(&restart_notifier_list, >> + reboot_mode, cmd); > > It would be a bit neater to have a helper function to perform the call, > rather than directly accessing the notifier list. Apart from anything > else, this hides the fact that the core code (presently!) uses the > blocking_ style notifiers. > Introduced kernel_restart_notify (proposals for better names welcome). As a side effect, moved restart_notifier_list into kernel/reboot.c and made it static. Thanks, Guenter