From: Robert Yang <liezhi.yang@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] image.bbclass/buildtools-tarball: cleanup the RDEPENDS
Date: Tue, 8 Jul 2014 09:47:45 +0800 [thread overview]
Message-ID: <53BB4DC1.9040202@windriver.com> (raw)
In-Reply-To: <1404776235.1458.51.camel@ted>
On 07/08/2014 07:37 AM, Richard Purdie wrote:
> On Fri, 2014-07-04 at 02:16 -0700, Robert Yang wrote:
>> The "RDEPENDS =" should be replaced by RDEPENDS_${PN}, the similar to
>> RRECOMMENDS
>
> Why?
>
> PACKAGES = "" for these recipes so there is no ${PN} package to add
> these dependencies too?
Ah, right, we should not set this if no PACKAGES.
>
> I suspect this is from your image class modifications but did you test
> without those modifications?
Yes, it is from the image class modifications. I tested it separately,
the bitbake core-image-minimal buildtools-tarball were the same w/o
these changes, I don't know why it works after your explanations, I
tried to print the self.rdepends_pkg from cache.py after patched:
self.rdepends_pkg: {'core-image-minimal': ['packagegroup-core-boot',
'run-postinsts', 'run-postinsts']}
maybe that's why it works.
Anyway, we should drop this since PACKAGES = "".
// Robert
>
> Cheers,
>
> Richard
>
>
>
prev parent reply other threads:[~2014-07-08 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 9:16 [PATCH 0/1] image.bbclass/buildtools-tarball: cleanup the RDEPENDS Robert Yang
2014-07-04 9:16 ` [PATCH 1/1] " Robert Yang
2014-07-07 23:37 ` Richard Purdie
2014-07-08 1:47 ` Robert Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BB4DC1.9040202@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.