From: Alexandre Courbot <acourbot@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2] power: poweroff: gpio: convert to use descriptors
Date: Tue, 8 Jul 2014 11:29:43 +0900 [thread overview]
Message-ID: <53BB5797.1090105@nvidia.com> (raw)
In-Reply-To: <1404729272-17873-1-git-send-email-linus.walleij@linaro.org>
On 07/07/2014 07:34 PM, Linus Walleij wrote:
> This switches the GPIO poweroff driver to use GPIO descriptors
> rather than numeral GPIOs. We get rid of the specific inversion
> handling as GPIO descriptors know if they are active low or
> high and can assert the line properly, so we do not need to
> check the flag OF_GPIO_ACTIVE_LOW returned from the old call
> of_get_gpio_flags() anymore.
>
> Also convert to use managed resources and use dev_* message
> printing while we're at it.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> 1 file changed, 19 insertions(+), 33 deletions(-)
This is what I like with these gpiod conversion patches.
next prev parent reply other threads:[~2014-07-08 2:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 10:34 [PATCH v2] power: poweroff: gpio: convert to use descriptors Linus Walleij
2014-07-08 2:29 ` Alexandre Courbot [this message]
2014-07-16 18:43 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BB5797.1090105@nvidia.com \
--to=acourbot@nvidia.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.