From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Yanfei Subject: Re: [PATCH v11 2/7] x86: add pmd_[dirty|mkclean] for THP Date: Tue, 8 Jul 2014 14:25:51 +0800 Message-ID: <53BB8EEF.6050101@cn.fujitsu.com> References: <1404799424-1120-1-git-send-email-minchan@kernel.org> <1404799424-1120-3-git-send-email-minchan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404799424-1120-3-git-send-email-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Minchan Kim Cc: Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , "Kirill A. Shutemov" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-api@vger.kernel.org On 07/08/2014 02:03 PM, Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org > Acked-by: Kirill A. Shutemov > Signed-off-by: Minchan Kim Acked-by: Zhang Yanfei > --- > arch/x86/include/asm/pgtable.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 0ec056012618..329865799653 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -104,6 +104,11 @@ static inline int pmd_young(pmd_t pmd) > return pmd_flags(pmd) & _PAGE_ACCESSED; > } > > +static inline int pmd_dirty(pmd_t pmd) > +{ > + return pmd_flags(pmd) & _PAGE_DIRTY; > +} > + > static inline int pte_write(pte_t pte) > { > return pte_flags(pte) & _PAGE_RW; > @@ -267,6 +272,11 @@ static inline pmd_t pmd_mkold(pmd_t pmd) > return pmd_clear_flags(pmd, _PAGE_ACCESSED); > } > > +static inline pmd_t pmd_mkclean(pmd_t pmd) > +{ > + return pmd_clear_flags(pmd, _PAGE_DIRTY); > +} > + > static inline pmd_t pmd_wrprotect(pmd_t pmd) > { > return pmd_clear_flags(pmd, _PAGE_RW); > -- Thanks. Zhang Yanfei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) by kanga.kvack.org (Postfix) with ESMTP id ED0B5900002 for ; Tue, 8 Jul 2014 02:26:28 -0400 (EDT) Received: by mail-pd0-f176.google.com with SMTP id ft15so6639098pdb.35 for ; Mon, 07 Jul 2014 23:26:28 -0700 (PDT) Received: from heian.cn.fujitsu.com ([59.151.112.132]) by mx.google.com with ESMTP id bu3si42755634pbb.98.2014.07.07.23.26.26 for ; Mon, 07 Jul 2014 23:26:27 -0700 (PDT) Message-ID: <53BB8EEF.6050101@cn.fujitsu.com> Date: Tue, 8 Jul 2014 14:25:51 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v11 2/7] x86: add pmd_[dirty|mkclean] for THP References: <1404799424-1120-1-git-send-email-minchan@kernel.org> <1404799424-1120-3-git-send-email-minchan@kernel.org> In-Reply-To: <1404799424-1120-3-git-send-email-minchan@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , "Kirill A. Shutemov" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org On 07/08/2014 02:03 PM, Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Acked-by: Kirill A. Shutemov > Signed-off-by: Minchan Kim Acked-by: Zhang Yanfei > --- > arch/x86/include/asm/pgtable.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 0ec056012618..329865799653 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -104,6 +104,11 @@ static inline int pmd_young(pmd_t pmd) > return pmd_flags(pmd) & _PAGE_ACCESSED; > } > > +static inline int pmd_dirty(pmd_t pmd) > +{ > + return pmd_flags(pmd) & _PAGE_DIRTY; > +} > + > static inline int pte_write(pte_t pte) > { > return pte_flags(pte) & _PAGE_RW; > @@ -267,6 +272,11 @@ static inline pmd_t pmd_mkold(pmd_t pmd) > return pmd_clear_flags(pmd, _PAGE_ACCESSED); > } > > +static inline pmd_t pmd_mkclean(pmd_t pmd) > +{ > + return pmd_clear_flags(pmd, _PAGE_DIRTY); > +} > + > static inline pmd_t pmd_wrprotect(pmd_t pmd) > { > return pmd_clear_flags(pmd, _PAGE_RW); > -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752863AbaGHG02 (ORCPT ); Tue, 8 Jul 2014 02:26:28 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:20320 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751704AbaGHG01 (ORCPT ); Tue, 8 Jul 2014 02:26:27 -0400 X-IronPort-AV: E=Sophos;i="5.00,855,1396972800"; d="scan'208";a="32980056" Message-ID: <53BB8EEF.6050101@cn.fujitsu.com> Date: Tue, 8 Jul 2014 14:25:51 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131030 Thunderbird/17.0.10 MIME-Version: 1.0 To: Minchan Kim CC: Andrew Morton , , , Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , "Kirill A. Shutemov" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Subject: Re: [PATCH v11 2/7] x86: add pmd_[dirty|mkclean] for THP References: <1404799424-1120-1-git-send-email-minchan@kernel.org> <1404799424-1120-3-git-send-email-minchan@kernel.org> In-Reply-To: <1404799424-1120-3-git-send-email-minchan@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.225.89] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2014 02:03 PM, Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Acked-by: Kirill A. Shutemov > Signed-off-by: Minchan Kim Acked-by: Zhang Yanfei > --- > arch/x86/include/asm/pgtable.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 0ec056012618..329865799653 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -104,6 +104,11 @@ static inline int pmd_young(pmd_t pmd) > return pmd_flags(pmd) & _PAGE_ACCESSED; > } > > +static inline int pmd_dirty(pmd_t pmd) > +{ > + return pmd_flags(pmd) & _PAGE_DIRTY; > +} > + > static inline int pte_write(pte_t pte) > { > return pte_flags(pte) & _PAGE_RW; > @@ -267,6 +272,11 @@ static inline pmd_t pmd_mkold(pmd_t pmd) > return pmd_clear_flags(pmd, _PAGE_ACCESSED); > } > > +static inline pmd_t pmd_mkclean(pmd_t pmd) > +{ > + return pmd_clear_flags(pmd, _PAGE_DIRTY); > +} > + > static inline pmd_t pmd_wrprotect(pmd_t pmd) > { > return pmd_clear_flags(pmd, _PAGE_RW); > -- Thanks. Zhang Yanfei