All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: hanpt@linux.vnet.ibm.com
Cc: LTP <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [RFC PATCH] regression test for 64bit sendfile capped at 2G
Date: Tue, 8 Jul 2014 15:46:05 +0800	[thread overview]
Message-ID: <53BBA1BD.2050902@cn.fujitsu.com> (raw)
In-Reply-To: <20140707065140.GA4421@localhost.localdomain>

Hi,

On 07/07/2014 02:51 PM, Han Pingtian wrote:
> On Tue, Jul 08, 2014 at 02:33:42PM +0800, Xiaoguang Wang wrote:
>> Hi,
>>
>> On 07/04/2014 11:16 AM, Han Pingtian wrote:
>>> Hi,
>>>
>>> Please review this patch. Thanks.
>>>
>>> There is a bug on 64bit sendfile() with large file, please see
>>> https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-June/118128.html
>>> for details.
>>
>> I'd like to ask an irrelevant question about that where can we get such bug report or similar issues
>> about syscalls from a stable place(url), or how did you found this issue, thanks.
>>
>> Give that currently there are 1039 test cases about syscalls in LTP(cat runtest/syscalls | grep -v "^#" | sed -e '/^$/d' | wc -l),
>> we can tell that syscalls is a very big test suite in LTP, so I'd like to add all similar regression test about
>> syscalls to LTP, which will expand ltp's test coverage, thanks. 
>>
>> Regards,
>> Xiaoguang Wang
>>
> Thanks for your reply. I knew this problem just by accidental. It wasn't
> found by me, but someone else. We are asked why we couldn't find it at
> first time though we had run ltp to test the syscalls. So I think it
> would be better to include a regession test for it to ltp. I think we
> can find out all those regressions by mointoring bug report web site and
> kernel's mailing list and something like these.

Yeah, kernel mail list would be the best place to find such issues, but usually
it needs more time to figure them out :)

As for you patch, I don't know whether you have read the test-writing-guidelines.txt first, if not,
please see https://github.com/linux-test-project/ltp/blob/master/doc/test-writing-guidelines.txt.
For example, there are already many safe_* in ltp, you can use them, which will simplify your error checking, thanks.

Regards,
Xiaoguang Wang 



> 
> 
> ------------------------------------------------------------------------------
> Open source business process management suite built on Java and Eclipse
> Turn processes into business applications with Bonita BPM Community Edition
> Quickly connect people, data, and systems into organized workflows
> Winner of BOSSIE, CODIE, OW2 and Gartner awards
> http://p.sf.net/sfu/Bonitasoft
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 


------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2014-07-07  7:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04  3:16 [LTP] [RFC PATCH] regression test for 64bit sendfile capped at 2G Han Pingtian
2014-07-07 12:14 ` Jan Stancek
2014-07-08  7:23   ` Han Pingtian
2014-07-08 10:36     ` Jan Stancek
2014-07-08 11:55       ` Jan Stancek
2014-07-08 12:30         ` Jan Stancek
2014-07-08 14:42           ` Han Pingtian
2014-07-14  7:40             ` Jan Stancek
2014-07-08  6:33 ` Xiaoguang Wang
2014-07-07  6:51   ` Han Pingtian
2014-07-08  7:46     ` Xiaoguang Wang [this message]
2014-07-07 11:44       ` Han Pingtian
2014-07-15 10:10   ` chrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BBA1BD.2050902@cn.fujitsu.com \
    --to=wangxg.fnst@cn.fujitsu.com \
    --cc=hanpt@linux.vnet.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.