All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel@lists.xensource.com
Cc: v1ne2go@gmail.com, David Vrabel <david.vrabel@citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [RFC PATCH 0/2] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem
Date: Tue, 8 Jul 2014 09:32:38 +0100	[thread overview]
Message-ID: <53BBACA6.9040007@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407072007470.27641@kaball.uk.xensource.com>

Hi Stefano,

(Drop Linux ARM as my comment is only Xen specific and avoid spamming 
the Linux ML)

On 07/07/14 21:24, Stefano Stabellini wrote:
> diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_table.h
> index eac8a70..95519c5 100644
> --- a/xen/include/asm-arm/grant_table.h
> +++ b/xen/include/asm-arm/grant_table.h
> @@ -34,7 +34,7 @@ static inline int replace_grant_supported(void)
>        (i < max_nr_grant_frames)) ? 0 : (d->arch.grant_table_gpfn[i]))
>
>   #define gnttab_need_iommu_mapping(d)                    \
> -    (is_domain_direct_mapped(d) && need_iommu(d))
> +    (is_domain_direct_mapped(d))

I suspect you tried this series on Midway with SMMU enabled, right?

This patch won't work on platform with iommu disabled (see check in 
iommu_{,un}map_page) and if we are using an other driver than the SMMU.

This is because the mapping is drivers specific.

>   #endif /* __ASM_GRANT_TABLE_H__ */
>   /*

-- 
Julien Grall

  parent reply	other threads:[~2014-07-08  8:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07 20:24 [RFC PATCH 0/2] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem Stefano Stabellini
2014-07-07 20:24 ` Stefano Stabellini
2014-07-07 20:26 ` [RFC PATCH 1/2] xen/arm: reimplement xen_dma_unmap_page & friends Stefano Stabellini
2014-07-07 20:26   ` Stefano Stabellini
2014-07-07 20:26 ` [RFC PATCH 2/2] xen/arm: remove mach_to_phys rbtree Stefano Stabellini
2014-07-07 20:26   ` Stefano Stabellini
2014-07-08  8:32 ` Julien Grall [this message]
2014-07-08  9:37 ` [Xen-devel] [RFC PATCH 0/2] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem Julien Grall
2014-07-08  9:37   ` Julien Grall
2014-07-08 10:50 ` David Vrabel
2014-07-08 10:50   ` David Vrabel
2014-07-08 11:00   ` Stefano Stabellini
2014-07-08 11:00     ` Stefano Stabellini
2014-07-08 11:06   ` Ian Campbell
2014-07-08 11:06     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BBACA6.9040007@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=v1ne2go@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.