From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH 4/4] ACPI: Make EC debugfs depend on X86 || IA64 in Kconfig Date: Tue, 08 Jul 2014 17:23:16 +0800 Message-ID: <53BBB884.5000005@linaro.org> References: <1404290847-7671-1-git-send-email-hanjun.guo@linaro.org> <1404290847-7671-5-git-send-email-hanjun.guo@linaro.org> <200683000.sgUJl2AyWR@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-we0-f169.google.com ([74.125.82.169]:61950 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbaGHJXU (ORCPT ); Tue, 8 Jul 2014 05:23:20 -0400 Received: by mail-we0-f169.google.com with SMTP id t60so5660032wes.14 for ; Tue, 08 Jul 2014 02:23:19 -0700 (PDT) In-Reply-To: <200683000.sgUJl2AyWR@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Catalin Marinas , Graeme Gregory , Tony Luck , Thomas Gleixner , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org On 2014=E5=B9=B407=E6=9C=8808=E6=97=A5 05:16, Rafael J. Wysocki wrote: > On Wednesday, July 02, 2014 04:47:26 PM Hanjun Guo wrote: >> Since EC (Embedded controller) needs SCI for the interupt which >> is not available on ARM64, make the EC debugfs depend on X86 || IA64 >> only in the Kconfig file. >> >> Reviewed-by: Grant Likely >> Signed-off-by: Hanjun Guo >> --- >> drivers/acpi/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig >> index 0e6f72d..7de5e3f 100644 >> --- a/drivers/acpi/Kconfig >> +++ b/drivers/acpi/Kconfig >> @@ -69,6 +69,7 @@ config ACPI_PROCFS_POWER >> =20 >> config ACPI_EC_DEBUGFS >> tristate "EC read/write access through /sys/kernel/debug/ec" >> + depends on X86 || IA64 > This is totally inconsistent with the other patches in the series whe= re you > define per-arch symbols for similar things. In addition to that, do = we need > to build ec.c on ARM at all? Yes, EC will be needed on ARM. This patch is not needed after some more consideration, I will drop it. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Tue, 08 Jul 2014 17:23:16 +0800 Subject: [PATCH 4/4] ACPI: Make EC debugfs depend on X86 || IA64 in Kconfig In-Reply-To: <200683000.sgUJl2AyWR@vostro.rjw.lan> References: <1404290847-7671-1-git-send-email-hanjun.guo@linaro.org> <1404290847-7671-5-git-send-email-hanjun.guo@linaro.org> <200683000.sgUJl2AyWR@vostro.rjw.lan> Message-ID: <53BBB884.5000005@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2014?07?08? 05:16, Rafael J. Wysocki wrote: > On Wednesday, July 02, 2014 04:47:26 PM Hanjun Guo wrote: >> Since EC (Embedded controller) needs SCI for the interupt which >> is not available on ARM64, make the EC debugfs depend on X86 || IA64 >> only in the Kconfig file. >> >> Reviewed-by: Grant Likely >> Signed-off-by: Hanjun Guo >> --- >> drivers/acpi/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig >> index 0e6f72d..7de5e3f 100644 >> --- a/drivers/acpi/Kconfig >> +++ b/drivers/acpi/Kconfig >> @@ -69,6 +69,7 @@ config ACPI_PROCFS_POWER >> >> config ACPI_EC_DEBUGFS >> tristate "EC read/write access through /sys/kernel/debug/ec" >> + depends on X86 || IA64 > This is totally inconsistent with the other patches in the series where you > define per-arch symbols for similar things. In addition to that, do we need > to build ec.c on ARM at all? Yes, EC will be needed on ARM. This patch is not needed after some more consideration, I will drop it. Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753503AbaGHJXX (ORCPT ); Tue, 8 Jul 2014 05:23:23 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:65317 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbaGHJXU (ORCPT ); Tue, 8 Jul 2014 05:23:20 -0400 Message-ID: <53BBB884.5000005@linaro.org> Date: Tue, 08 Jul 2014 17:23:16 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: Catalin Marinas , Graeme Gregory , Tony Luck , Thomas Gleixner , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org Subject: Re: [PATCH 4/4] ACPI: Make EC debugfs depend on X86 || IA64 in Kconfig References: <1404290847-7671-1-git-send-email-hanjun.guo@linaro.org> <1404290847-7671-5-git-send-email-hanjun.guo@linaro.org> <200683000.sgUJl2AyWR@vostro.rjw.lan> In-Reply-To: <200683000.sgUJl2AyWR@vostro.rjw.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年07月08日 05:16, Rafael J. Wysocki wrote: > On Wednesday, July 02, 2014 04:47:26 PM Hanjun Guo wrote: >> Since EC (Embedded controller) needs SCI for the interupt which >> is not available on ARM64, make the EC debugfs depend on X86 || IA64 >> only in the Kconfig file. >> >> Reviewed-by: Grant Likely >> Signed-off-by: Hanjun Guo >> --- >> drivers/acpi/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig >> index 0e6f72d..7de5e3f 100644 >> --- a/drivers/acpi/Kconfig >> +++ b/drivers/acpi/Kconfig >> @@ -69,6 +69,7 @@ config ACPI_PROCFS_POWER >> >> config ACPI_EC_DEBUGFS >> tristate "EC read/write access through /sys/kernel/debug/ec" >> + depends on X86 || IA64 > This is totally inconsistent with the other patches in the series where you > define per-arch symbols for similar things. In addition to that, do we need > to build ec.c on ARM at all? Yes, EC will be needed on ARM. This patch is not needed after some more consideration, I will drop it. Thanks Hanjun