From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 2/2] make: Make "src-tarball" target actually make a source tarball Date: Tue, 8 Jul 2014 12:00:11 +0100 Message-ID: <53BBCF3B.3030507@eu.citrix.com> References: <1404317712-4191-1-git-send-email-george.dunlap@eu.citrix.com> <1404317712-4191-2-git-send-email-george.dunlap@eu.citrix.com> <1404376154.11440.9.camel@kazak.uk.xensource.com> <53B55122.9050002@eu.citrix.com> <21435.48893.415492.386853@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21435.48893.415492.386853@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Ian Campbell , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/08/2014 10:50 AM, Ian Jackson wrote: > George Dunlap writes ("Re: [PATCH 2/2] make: Make "src-tarball" target actually make a source tarball"): >> On 07/03/2014 09:29 AM, Ian Campbell wrote: >>> FWIW I think you could avoid much of this pushd/popd stuff with tar -C >>> and git --git-dir= (perhaps --work-dir, not sure for git archive). >> >> The --git-dir think seemed to work differently enough to hg's "-C" >> option that I didn't really trust it. If you think it's better I can >> try to work it out. > > Firstly, thanks for cleaning up this area, which sorely needs it. > > Please don't. I wouldn't really trust it either :-). > > Instead of pushd/popd, you might consider ( ). Well I've rewritten it with --git-dir already, and it looks a lot cleaner. I'll send that version and you can see what you think. (May be a few days.) -George