From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4Vng-0001v9-DD for qemu-devel@nongnu.org; Tue, 08 Jul 2014 09:51:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4Vna-0005po-Ky for qemu-devel@nongnu.org; Tue, 08 Jul 2014 09:51:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33080 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4Vna-0005pf-EP for qemu-devel@nongnu.org; Tue, 08 Jul 2014 09:51:10 -0400 Message-ID: <53BBF74C.3060104@suse.de> Date: Tue, 08 Jul 2014 15:51:08 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1404716892-15600-1-git-send-email-eric.auger@linaro.org> <1404716892-15600-5-git-send-email-eric.auger@linaro.org> In-Reply-To: <1404716892-15600-5-git-send-email-eric.auger@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/7] hw/arm/virt: Support dynamically spawned sysbus devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, kim.phillips@freescale.com, a.rigo@virtualopensystems.com Cc: peter.maydell@linaro.org, patches@linaro.org, stuart.yoder@freescale.com, alex.williamson@redhat.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu On 07.07.14 09:08, Eric Auger wrote: > Allows sysbus devices to be instantiated from command line by > using -device option > > --- > > Inspired from what Alex Graf did in ppc e500 > https://lists.gnu.org/archive/html/qemu-ppc/2014-07/msg00012.html > > Signed-off-by: Alexander Graf > Signed-off-by: Eric Auger > --- > hw/arm/virt.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 57 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index eeecdbf..3a21db4 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -40,6 +40,8 @@ > #include "exec/address-spaces.h" > #include "qemu/bitops.h" > #include "qemu/error-report.h" > +#include "hw/misc/platform_devices.h" > +#include "hw/vfio/vfio-platform.h" > > #define NUM_VIRTIO_TRANSPORTS 32 > > @@ -57,6 +59,14 @@ > #define GIC_FDT_IRQ_PPI_CPU_START 8 > #define GIC_FDT_IRQ_PPI_CPU_WIDTH 8 > > +#define MACHVIRT_PLATFORM_BASE 0xa004000 That's an odd address for a 128MB window. Can you make it 128MB aligned? Maybe move the virtio region behind this one? With a bit of smartness we don't need a virtio-mmio region with this patch set anymore btw. We could just generate the virtio-mmio devices on our platform bus on the fly. > +#define MACHVIRT_PLATFORM_HOLE (128ULL * 1024 * 1024) /* 128 MB */ As Scott mentioned in the e500 review round, "hole" is an odd name ;). Alex