Re: [PATCH v2] ARM: dts: exynos 3250: add hsotg and usb2phy device nodes

[Tomasz Figa <t.figa@samsung.com>]

On 07.07.2014 11:39, Marek Szyprowski wrote:
> This patch adds device tree nodes required to enable support for USB
> device controller.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> Changelog:
> v2:
> - removed phandle to syscon, because mode switch register is not needed for 3250.
> ---
>  arch/arm/boot/dts/exynos3250.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index eb457620975b..64a0ef44325a 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -309,6 +309,27 @@
>  			status = "disabled";
>  		};
>  
> +		hsotg: hsotg@12480000 {
> +			compatible = "samsung,s3c6400-hsotg";
> +			reg = <0x12480000 0x20000>;
> +			interrupts = <0 141 0>;
> +			clocks = <&cmu CLK_USBOTG>;
> +			clock-names = "otg";
> +			phys = <&exynos_usbphy 0>;
> +			phy-names = "usb2-phy";
> +			status = "disabled";
> +		};
> +
> +		exynos_usbphy: exynos-usbphy@125B0000 {
> +			compatible = "samsung,exynos3250-usb2-phy";
> +			reg = <0x125B0000 0x100>;
> +			samsung,pmureg-phandle = <&pmu_system_controller>;
> +			clocks = <&cmu CLK_USBOTG>, <&xusbxti>;
> +			clock-names = "phy", "ref";

Are you sure these are right clocks for Exynos3250? I thought the ref
clock was supposed to be SCLK_UPLL on this SoC.

Best regards,
Tomasz