From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 2/2] xen/grant-table: remove support for V2 tables Date: Tue, 8 Jul 2014 18:51:20 +0100 Message-ID: <53BC2F98.4030409@citrix.com> References: <1404296729-23606-1-git-send-email-david.vrabel@citrix.com> <1404296729-23606-3-git-send-email-david.vrabel@citrix.com> <20140708171023.GA3552@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X4ZY4-0008TY-Kc for xen-devel@lists.xenproject.org; Tue, 08 Jul 2014 17:51:24 +0000 In-Reply-To: <20140708171023.GA3552@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 08/07/14 18:10, Konrad Rzeszutek Wilk wrote: > On Wed, Jul 02, 2014 at 11:25:29AM +0100, David Vrabel wrote: >> Since 11c7ff17c9b6dbf3a4e4f36be30ad531a6cf0ec9 (xen/grant-table: Force >> to use v1 of grants.) the code for V2 grant tables is not used. > > I get compile warnings with this patch: > WARNING: vmlinux.o(.text+0x40268a): Section mismatch in reference from the function gnttab_init() to the function .init.text:arch_gnttab > _init() > The function gnttab_init() references > the function __init arch_gnttab_init(). > This is often because gnttab_init lacks a __init > annotation or the annotation of arch_gnttab_init is wrong. Thanks. I'd missed this warning (despite having the appropriate option turned on). But it's patch #1 that broke this. David